Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clang-tidy: missing rule with id clang-diagnostic-error ? #1747

Closed
stalb opened this issue Aug 12, 2019 · 0 comments · Fixed by #1754
Closed

clang-tidy: missing rule with id clang-diagnostic-error ? #1747

stalb opened this issue Aug 12, 2019 · 0 comments · Fixed by #1754
Assignees
@guwirth
Labels
enhancement
Milestone
1.3.1

Comments

@stalb
Copy link
Contributor

stalb commented Aug 12, 2019

There is a test to verify that clang-tidy sensor correctly reports clang errors ([clang-diagnostic-error]):

However the is no corresponding rule in clang-tidy repository.
That make sense since guwirth said:

precondition is that source code is error free. [...] Syntax analysis is normally not the job of an static code analyzer

So what should we do ? Add an clang-diagnostic-error rule or leave everything as it is ?

see also #1742 #1702
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guwirth guwirth

Labels
enhancement
Milestone
1.3.1
Development

Successfully merging a pull request may close this issue.

clang-tidy: add 'clang-diagnostic-error' rule
2 participants
@stalb @guwirth