Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix: Inner Outer Inner wall ordering mode failed to reorder in certain edge cases with arachne #7134

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Bug fix: Inner Outer Inner wall ordering mode failed to reorder in certain edge cases with arachne #7134

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0cfbe3f
Bug fix: Inner Outer Inner failed to reorder in certain edge cases
igiannakas Oct 16, 2024
34a76af
Fixing IOI proximity search spacing calculations
igiannakas Oct 22, 2024
8a1f03d
Merge branch 'main' into Bug-fix-Inner-Outer-Inner-failed-to-reorder-…
igiannakas Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/libslic3r/PerimeterGenerator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3113,11 +3113,15 @@ void PerimeterGenerator::process_arachne()
bringContoursToFront(ordered_extrusions);
std::vector<PerimeterGeneratorArachneExtrusion> reordered_extrusions;

// Get searching thresholds. For an external perimeter we take the middle of the external perimeter width, split it in two, add the spacing to the internal perimeter and add half the internal perimeter width.
// This should get us to the middle of the internal perimeter. We then scale by 10% up for safety margin.
coord_t threshold_external = (this->ext_perimeter_flow.scaled_width()/2+this->ext_perimeter_flow.scaled_spacing()+this->perimeter_flow.scaled_width()/2) * 1.1;
// For the intenal perimeter threshold, the distance is the perimeter width plus the spacing, scaled by 10% for safety margin.
coord_t threshold_internal = (this->perimeter_flow.scaled_width()+this->perimeter_flow.scaled_spacing()) * 1.1;
// Debug statement to print spacing values:
//printf("External threshold - Ext perimeter: %d Ext spacing: %d Int perimeter: %d Int spacing: %d\n", this->ext_perimeter_flow.scaled_width(),this->ext_perimeter_flow.scaled_spacing(),this->perimeter_flow.scaled_width(), this->perimeter_flow.scaled_spacing());

// Get searching thresholds. For an external perimeter we take the external perimeter spacing/2 plus the internal perimeter spacing/2 and expand by 3% to cover
// rounding errors
coord_t threshold_external = (this->ext_perimeter_flow.scaled_spacing()/2 + this->perimeter_flow.scaled_spacing()/2)*1.03;

// For the intenal perimeter threshold, the distance is the internal perimeter spacing expanded by 3% to cover rounding errors.
coord_t threshold_internal = this->perimeter_flow.scaled_spacing() * 1.03;

// Re-order extrusions based on distance
// Alorithm will aggresively optimise for the appearance of the outermost perimeter
Expand Down