Bug fix: Inner Outer Inner wall ordering mode failed to reorder in certain edge cases with arachne #7134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igiannakas
changed the title
|
Hi! I am the edge case, and the problem is completely solved. Here's a before and after of how the problem looked on the part. |
|
@SoftFever, any chance we can sneak that in 2.2? 😀😀 |
|
Upon further investigation, the threshold expansion was not the problem, but rather I was incorrectly using both line width and line spacing to identify proximity. As spacing already contains the line width, that was resulting in the search radius being larger than needed, incorrectly attaching perimeters to neighbouring islands. This PR now fixes this issue by using the correct spacing thresholds for the proximity search for IOI, expanded by 3% to account for any math rounding issues. |
Sure! |
igiannakas
deleted the
Bug-fix-Inner-Outer-Inner-failed-to-reorder-in-certain-edge-cases
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The proximity search algorithm for IOI was incorrectly using both line width and line spacing to identify proximity. As spacing already contains the line width, that was resulting in the search radius being larger than needed, incorrectly attaching perimeters to neighbouring islands.
This PR fixes this issue by using the correct spacing thresholds for the proximity search for IOI, expanded by 3% to account for any math rounding issues.
Screenshots/Recordings/Graphs
Before
The middle bridge was incorrectly "attached" to the previous island due to proximity calculation being tripped up due to the artificially increased overlap.
After:
Correctly sequenced perimeters as per IOI