fix: crash lors de la sélection d'une suggestion #6202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-maillot
force-pushed
the
fix/crash-on-select-suggestion
branch
from
64fc51f to
229f4e5
Compare
m-maillot
commented
Oct 10, 2024
| @@ -14,7 +14,7 @@ export const useLayoutTracking = () => { | |||
| sendEvent({ | |||
| category: LayoutCategory.SELECTED_SUGGESTION, | |||
| action: query, | |||
| value: suggestion, | |||
| name: suggestion, | |||
There was a problem hiding this comment.
Le bug était ici :)
carolineBda
reviewed
Oct 10, 2024
m-maillot
force-pushed
the
fix/crash-on-select-suggestion
branch
from
229f4e5 to
bff2b1d
Compare
maxgfr
approved these changes
Oct 10, 2024
m-maillot
had a problem deploying
to
review-auto
GitHub Actions
Failure
m-maillot
force-pushed
the
fix/crash-on-select-suggestion
branch
from
8082b89 to
7e9e996
Compare
m-maillot
force-pushed
the
fix/crash-on-select-suggestion
branch
from
7e9e996 to
649bdcc
Compare
Co-authored-by: Caroline <[email protected]>
m-maillot
force-pushed
the
fix/crash-on-select-suggestion
branch
from
649bdcc to
352cfed
Compare
|
🎉 Deployment for commit 352cfed : IngressesDocker images
|
carolineBda
had a problem deploying
to
review-auto
GitHub Actions
Failure
m-maillot
added a commit
that referenced
this pull request
Oct 15, 2024
* fix: dsfr * fix: dsfr * fix: dsfr * fix: tests * fix: build * fix: build * fix: build * feat(dsfr): ajout du footer (#6079) * feat: add code * fix: tests * fix: tests * fix: tests * fix: tests * fix: tests * fix: dernier titi * fix: autoclick * fix: bug * feat(css): ajout de la lib `panda-css` (zero-runtime) (#6085) * fix: pandacss * fix: build * fix: build * feat(dsfr): ajout de la page stats (#6090) * fix: pandacss * fix: build * fix: build * fix(stats): add page * fix: stats * fix: tests * fix: tests * Update packages/code-du-travail-frontend/src/modules/mentions-legales/index.tsx Co-authored-by: Martial Maillot <[email protected]> * fix(recherche): remonter les pré-qualifiés dans la recherche (#6082) * chore(release): version 4.151.1 * fix(csp): remove reporting on sentry (#6092) * fix: config * fix: config * fix: config * empty * fix: config * empty * Update packages/code-du-travail-frontend/src/modules/mentions-legales/index.tsx Co-authored-by: Martial Maillot <[email protected]> * Update packages/code-du-travail-frontend/src/modules/mentions-legales/index.tsx Co-authored-by: Martial Maillot <[email protected]> * fix: config * chore(dsfr): mise à jour de la version DSFR * fix(dsfr): ignore les exceptions d'hydratation * feat(tests): ajout du module de testing (#6096) * fix: tests * fix: tests * fix: command * fix: merge date * fix: tests * fix: tests * fix: tests * fix: tests * fix(dsfr): ignore les exceptions d'hydratation * fix: readme * feat(DSFR): migration de la page article du code du travail (#6099) * feat: 6093 dsfr page politique de confidentialit (#6094) * feat: implémentation page politique confidentialité dsfr * chore: clean * fix: iframe dark mode * chore: refacto + e2e test * feat: convert a to Link * chore: review * chore: rename test --------- Co-authored-by: victor <[email protected]> * feat(dsfr): ajout des liens d'évitement (#6120) * feat(dsfr): migration de la page plan du site (#6097) * feat(dsfr): mise à jour des snapshots * feat(dsfr): mise à jour des snapshots * chore(dsfr): mise à jour de la lib DSFR * feat(dsfr): ajout du composant "Avez-vous trouvé une réponse à votre question" (#6121) * fix: merge date * fix: satisfaction * fix: retours preavis * fix: retours preavis * fix: tests * move feedback component to the page articleCodeDuTravail.tsx * clean-up css * fix: feedback * fix: feedback * fix: tests * fix: tests * feat(dsfr): création du composant "Besoin de plus d'information" (#6135) * fix: ui * fix: composant --------- Co-authored-by: carolineBda <[email protected]> Co-authored-by: Martial Maillot <[email protected]> * fix: retours * fix: tests * feat: nouvelle API pour les articles du code du travail (#6132) Co-authored-by: carolineBda <[email protected]> * fix(spec) : fix de la spec article-code-du-travail.spec.ts * fix(dsfr): ajout de la config pour supprimer le `insafe-inline` des `scripts` dans les `csp` (#6151) * feat(dsfr): ajout de matomo pour tracker les events (#6157) * fix: matomo * fix: matomo --------- Co-authored-by: Martial Maillot <[email protected]> * fix(feedback): ajout d'une logique de caractères restants (#6156) * fix: tests * feat: limiter à 500 caractères la saisie * feat: limiter à 500 caractères la saisie --------- Co-authored-by: Martial Maillot <[email protected]> * feat(dsfr): ajout du nouveau logo (#6159) * feat(dsfr): ajout des pages d'erreurs (404 + 500) (#6146) * fix: pages * fix: 404 * fix: tests * fix: tests * fix: tests * fix: lint * test error * fix errors * Fix spec * add button to test error page * feat: force error 500 for testing purpose * feat: revert errors --------- Co-authored-by: carolineBda <[email protected]> Co-authored-by: Martial Maillot <[email protected]> * feat: séparation des anciennes API et des nouvelles (#6183) * fix(article code du travail): retrait du tag Code du travail (#6182) * feat(config): correction de `husky`, ajout de `prettier` pour le formattage et de `lint-staged` pour runner le formattage au `precommit` (#6192) * fix: prettier * fix: prettier * fix: readme * fix: readme * fix: bug * fix: prettier * fix: prettier * fix: tests * fix: tests * fix: prettier * fix: prettier * fix: branch * merge dev * fix: crash lors de la sélection d'une suggestion (#6202) * fix: crash lors de la sélection d'une suggestion * Update packages/code-du-travail-frontend/src/modules/utils/events.ts Co-authored-by: Caroline <[email protected]> --------- Co-authored-by: Caroline <[email protected]> * fix: crash lors de la sélection d'une suggestion (#6209) * fix: crash lors de la sélection d'une suggestion * Update packages/code-du-travail-frontend/src/modules/utils/events.ts Co-authored-by: Caroline <[email protected]> --------- Co-authored-by: Martial Maillot <[email protected]> * fix(suggestion): style + move feedback into RichComponent (#6210) * fix: format --------- Co-authored-by: Caroline <[email protected]> Co-authored-by: Martial Maillot <[email protected]> Co-authored-by: Social Groovy Bot <[email protected]> Co-authored-by: Victor Zeinstra <[email protected]> Co-authored-by: victor <[email protected]> Co-authored-by: carolineBda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.