Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dsfr): ajout des premières pages et composants en DSFR #6078

Merged
merged 76 commits into from
Oct 15, 2024

Conversation

maxgfr
Copy link
Member

@maxgfr maxgfr commented Aug 22, 2024

fix #6070
fix #6072
fix #6077
fix #6087
fix #6089
fix #6100
fix #6134
fix #6116
fix #6114

@maxgfr maxgfr requested review from m-maillot and Viczei August 22, 2024 16:28
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Contributor

@m-maillot m-maillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est top l'utilisation du folder app !
Il faut que l'on discute de l'organisation des fichiers dans le dossier src. Je pense qu'il serait bien d'avoir un dossier comme tu as fait avec les nouveautés dsfr et à la fin on peut supprimer les fichiers en dehors de ce dossier.

* feat: add code

* fix: tests

* fix: tests
@maxgfr maxgfr changed the title feat(dsfr): ajout du header et du thème feat(dsfr): ajout du layout (header + footer) et création de la page mentions-legales Aug 27, 2024
Copy link

socket-security bot commented Aug 27, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@maxgfr maxgfr requested a review from m-maillot August 29, 2024 13:15
@maxgfr maxgfr marked this pull request as ready for review October 10, 2024 08:45
@maxgfr maxgfr requested a review from a team as a code owner October 10, 2024 08:45
* fix: crash lors de la sélection d'une suggestion

* Update packages/code-du-travail-frontend/src/modules/utils/events.ts

Co-authored-by: Caroline <[email protected]>

---------

Co-authored-by: Caroline <[email protected]>
Copy link

socket-security bot commented Oct 11, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@eslint/[email protected] None 0 14.2 kB eslintbot, openjsfoundation
npm/[email protected] environment, filesystem, unsafe 0 7.7 MB prettier-bot

🚮 Removed packages: npm/[email protected], npm/[email protected]

View full report↗︎

* fix: crash lors de la sélection d'une suggestion

* Update packages/code-du-travail-frontend/src/modules/utils/events.ts

Co-authored-by: Caroline <[email protected]>

---------

Co-authored-by: Martial Maillot <[email protected]>
Copy link

@m-maillot m-maillot merged commit d841f65 into dev Oct 15, 2024
22 of 23 checks passed
@m-maillot m-maillot deleted the maxgfr/dsfr-header branch October 15, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment