-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dsfr): ajout des premières pages et composants en DSFR #6078
Conversation
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C'est top l'utilisation du folder app
!
Il faut que l'on discute de l'organisation des fichiers dans le dossier src
. Je pense qu'il serait bien d'avoir un dossier comme tu as fait avec les nouveautés dsfr et à la fin on peut supprimer les fichiers en dehors de ce dossier.
packages/code-du-travail-frontend/src/dsfr/layout/fetchSuggestResults.ts
Outdated
Show resolved
Hide resolved
packages/code-du-travail-frontend/src/dsfr/layout/fetchSuggestResults.ts
Outdated
Show resolved
Hide resolved
* feat: add code * fix: tests * fix: tests
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
* fix: crash lors de la sélection d'une suggestion * Update packages/code-du-travail-frontend/src/modules/utils/events.ts Co-authored-by: Caroline <[email protected]> --------- Co-authored-by: Caroline <[email protected]>
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected], npm/[email protected] |
7ea1b26
to
36697b3
Compare
* fix: crash lors de la sélection d'une suggestion * Update packages/code-du-travail-frontend/src/modules/utils/events.ts Co-authored-by: Caroline <[email protected]> --------- Co-authored-by: Martial Maillot <[email protected]>
🎉 Deployment for commit 76c626b : IngressesDocker images
|
fix #6070
fix #6072
fix #6077
fix #6087
fix #6089
fix #6100
fix #6134
fix #6116
fix #6114