Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SCIM access token Datasource #557

Merged
merged 14 commits into from
Jun 4, 2021
Merged

Add SCIM access token Datasource #557

merged 14 commits into from
Jun 4, 2021

Conversation

ChrisIsidora
Copy link
Contributor

Added Datasource (Generate) SCIM Access Token. See #550

Test Plan

  • acceptance tests
  • unit tests

References

https://docs.snowflake.com/en/user-guide/scim-azure.html
*

@ChrisIsidora ChrisIsidora requested a review from a team as a code owner May 31, 2021 10:46
@ChrisIsidora ChrisIsidora requested a review from edulop91 May 31, 2021 10:46
@ChrisIsidora
Copy link
Contributor Author

@edulop91 This is related to #550

@alldoami
Copy link
Contributor

alldoami commented Jun 1, 2021

/ok-to-test sha=c40a034

@github-actions
Copy link

github-actions bot commented Jun 1, 2021

Integration tests failure for c40a034

@alldoami
Copy link
Contributor

alldoami commented Jun 1, 2021

/ok-to-test sha=079e311

@github-actions
Copy link

github-actions bot commented Jun 1, 2021

Integration tests failure for 079e311

@ChrisIsidora
Copy link
Contributor Author

@alldoami Acceptance tests should be passing now with the new error handling

@alldoami
Copy link
Contributor

alldoami commented Jun 1, 2021

/ok-to-test sha=58a1de1

@github-actions
Copy link

github-actions bot commented Jun 1, 2021

Integration tests failure for 58a1de1

@ChrisIsidora
Copy link
Contributor Author

@alldoami I think the integration test is failing because the scim integration is not there, should I skip the acceptance test or do you another way that the acceptance test could pass?

@alldoami
Copy link
Contributor

alldoami commented Jun 1, 2021

@ChrisIsidora let's merge your other PR first

@ChrisIsidora
Copy link
Contributor Author

@alldoami I updated the other PR #556 and already added the resource dependency in this PR. But the other PR should pass and be merged first

@ChrisIsidora ChrisIsidora mentioned this pull request Jun 3, 2021
Merged
2 tasks
@alldoami
Copy link
Contributor

alldoami commented Jun 4, 2021

/ok-to-test sha=7e9e0d4

@github-actions
Copy link

github-actions bot commented Jun 4, 2021

Integration tests failure for 7e9e0d4

@ChrisIsidora
Copy link
Contributor Author

@alldoami The Acceptance tests should be OK now.
image

@alldoami
Copy link
Contributor

alldoami commented Jun 4, 2021

/ok-to-test sha=9d3654c

@github-actions
Copy link

github-actions bot commented Jun 4, 2021

Integration tests success for 9d3654c

@ChrisIsidora
Copy link
Contributor Author

@alldoami Can you merge or do we need another ACC test for the last commit?

@alldoami
Copy link
Contributor

alldoami commented Jun 4, 2021

/ok-to-test sha=d627d7d

@github-actions
Copy link

github-actions bot commented Jun 4, 2021

Integration tests success for d627d7d

@ChrisIsidora ChrisIsidora requested a review from alldoami June 4, 2021 22:22
@alldoami alldoami merged commit c58f9e1 into Snowflake-Labs:main Jun 4, 2021
jtzero pushed a commit to rxrevu/terraform-provider-snowflake that referenced this pull request Aug 19, 2021
@ChrisIsidora @jtzero
Add SCIM access token Datasource (Snowflake-Labs#557)
40c1cb9
anton-chekanov pushed a commit to anton-chekanov/terraform-provider-snowflake that referenced this pull request Jan 25, 2022
@ChrisIsidora @anton-chekanov
Add SCIM access token Datasource (Snowflake-Labs#557)
edb3f29
daniepett pushed a commit to daniepett/terraform-provider-snowflake that referenced this pull request Feb 9, 2022
@ChrisIsidora
Add SCIM access token Datasource (Snowflake-Labs#557)
d385425
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edulop91 edulop91 Awaiting requested review from edulop91

@alldoami alldoami Awaiting requested review from alldoami

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrisIsidora @alldoami