Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SCIM Integration Resource #556

Merged
merged 15 commits into from
Jun 4, 2021
Merged

Add SCIM Integration Resource #556

merged 15 commits into from
Jun 4, 2021

Conversation

ChrisIsidora
Copy link
Contributor

@ChrisIsidora ChrisIsidora commented May 31, 2021 •
edited
Loading

Added SCIM Integration Resource (#549)

Test Plan

  • acceptance tests
  • unit tests…

References

See https://docs.snowflake.com/en/user-guide/scim.html

@ChrisIsidora ChrisIsidora requested a review from a team as a code owner May 31, 2021 09:46
@ChrisIsidora ChrisIsidora requested a review from alldoami May 31, 2021 09:46
@ChrisIsidora
Copy link
Contributor Author

@alldoami This is related to the feature request #549

@ChrisIsidora
Copy link
Contributor Author

@alldoami can you trigger the test after the latest changes?

@ChrisIsidora ChrisIsidora requested a review from alldoami June 1, 2021 21:12
@alldoami
Copy link
Contributor

alldoami commented Jun 1, 2021

/ok-to-test sha=691e58e

@github-actions
Copy link

github-actions bot commented Jun 1, 2021

Integration tests failure for 691e58e

@ChrisIsidora
Copy link
Contributor Author

@alldoami Removed Enabled property which cannot be set for SECURITY INTEGRATION with type=SCIM

@alldoami
Copy link
Contributor

alldoami commented Jun 1, 2021

/ok-to-test sha=a17e7f5

@github-actions
Copy link

github-actions bot commented Jun 1, 2021

Integration tests failure for a17e7f5

@ChrisIsidora
Copy link
Contributor Author

@alldoami Added the dependent resources to the acceptance tests. Can you check if it's ok now?

@ChrisIsidora ChrisIsidora mentioned this pull request Jun 1, 2021
Merged
2 tasks
@alldoami
Copy link
Contributor

alldoami commented Jun 2, 2021

/ok-to-test sha=808f6d2

@github-actions
Copy link

github-actions bot commented Jun 2, 2021

Integration tests failure for 808f6d2

@alldoami
Copy link
Contributor

alldoami commented Jun 2, 2021

This would be best if you could test locally and request my review when ready.

@ChrisIsidora
Copy link
Contributor Author

ChrisIsidora commented Jun 2, 2021 •
edited
Loading

@alldoami You are right, sorry for the inconvenience. I tested the acceptance test locally on my own Snowflake account, made some fixes and it seems to work now.

image

@alldoami
Copy link
Contributor

alldoami commented Jun 2, 2021

/ok-to-test sha=2cb5b18

@github-actions
Copy link

github-actions bot commented Jun 2, 2021

Integration tests failure for 2cb5b18

@ChrisIsidora
Copy link
Contributor Author

@alldoami Not sure why the acc test are failing. It does work on my snowflake account. See below, I made some changes to the resource id maybe that might help. For the unit test I saw that for the Generic alter builder there was no sorting which means that my alter unit test might fail sometimes because of the random order of the statement. That should be fixed now.

image

@alldoami
Copy link
Contributor

alldoami commented Jun 3, 2021

/ok-to-test sha=5bd10cb

@github-actions
Copy link

github-actions bot commented Jun 3, 2021

Integration tests failure for 5bd10cb

@ChrisIsidora
Copy link
Contributor Author

@alldoami Seems that okta provider already exists on the acc snowflake account. I removed Okta tests

@alldoami
Copy link
Contributor

alldoami commented Jun 3, 2021

/ok-to-test sha=f863df6

@github-actions
Copy link

github-actions bot commented Jun 3, 2021

Integration tests success for f863df6

@ChrisIsidora
Copy link
Contributor Author

@alldoami can this be merged so that I can work / update #557? Thanks in advance for your patience

jakeyheath
jakeyheath suggested changes Jun 3, 2021
View reviewed changes
pkg/resources/scim_integration.go Outdated Show resolved Hide resolved
pkg/resources/scim_integration.go Outdated Show resolved Hide resolved
pkg/resources/scim_integration.go Outdated Show resolved Hide resolved
pkg/resources/scim_integration.go Show resolved Hide resolved
pkg/snowflake/scim_integration.go Outdated Show resolved Hide resolved
pkg/snowflake/scim_integration.go Outdated Show resolved Hide resolved
pkg/snowflake/generic.go Outdated Show resolved Hide resolved
pkg/snowflake/generic.go Outdated Show resolved Hide resolved
@ChrisIsidora
Copy link
Contributor Author

@alldoami and @jacobrheath Can you please review the changes requested. Thanks!

@ChrisIsidora ChrisIsidora requested a review from jakeyheath June 4, 2021 10:09
@alldoami
Copy link
Contributor

alldoami commented Jun 4, 2021

/ok-to-test sha=15a53ae

@github-actions
Copy link

github-actions bot commented Jun 4, 2021

Integration tests success for 15a53ae

@alldoami alldoami merged commit 19d397d into Snowflake-Labs:main Jun 4, 2021
jtzero pushed a commit to rxrevu/terraform-provider-snowflake that referenced this pull request Aug 19, 2021
@ChrisIsidora @jtzero
Add SCIM Integration Resource (Snowflake-Labs#556)
e6c345c
anton-chekanov pushed a commit to anton-chekanov/terraform-provider-snowflake that referenced this pull request Jan 25, 2022
@ChrisIsidora @anton-chekanov
Add SCIM Integration Resource (Snowflake-Labs#556)
86413cb
daniepett pushed a commit to daniepett/terraform-provider-snowflake that referenced this pull request Feb 9, 2022
@ChrisIsidora
Add SCIM Integration Resource (Snowflake-Labs#556)
2c78464
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alldoami alldoami alldoami approved these changes

@jakeyheath jakeyheath Awaiting requested review from jakeyheath

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChrisIsidora @alldoami @jakeyheath