Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Removing broken test for external table #426

Merged
merged 12 commits into from
Jan 26, 2021

Conversation

alldoami
Copy link
Contributor

@alldoami alldoami commented Jan 21, 2021

This was found my looking at schema_acceptance_test.go and seeing the diff since they should be similar acceptance tests. Snowflake is case sensitive and the error was looking for a case varying string when it was actually just all uppercase since we didn't encase the strings in double quotes.

Error in tests:

Error: error creating externalTable jkdvwnnjek: 002003 (02000): SQL compilation error:
        Database 'JKDVWNNJEK' does not exist or not authorized.

diff: jkdvwnnjek and JKDVWNNJEK

Edit (1/26/2021): Removing this test because it is broken. We hit:

Error: error creating externalTable KZIGPDBWIY: 000603 (XX000): SQL execution internal error:
        Processing aborted due to error 300002:2823945773; incident 1761483.

which is unclear what the real reason for the failure is but we're guessing that is has to do with not being able to create a fake s3 bucket for the external stage. If we still want to keep this test, the prior commits to the last one will still need to be considered.

@alldoami alldoami requested a review from ryanking January 21, 2021 18:58
@alldoami alldoami requested a review from a team as a code owner January 21, 2021 18:58
@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #67281: Fix bug with TestAccExternalTable.

@alldoami alldoami changed the title [fix] Snowflake case sensitive names [fix] Snowflake case sensitive names for TestAccExternalTable Jan 21, 2021
@github-actions
Copy link

Integration tests failure for 22f95b7e7f9600cc8d94867e5d998de63f8e4f48

@github-actions
Copy link

Integration tests failure for dc537626a7d384cc13749d50dcc011c7632560ce

@github-actions
Copy link

Integration tests failure for e3352c2335e68cdb81c9692c0688cbf5822a19a0

1 similar comment
@github-actions
Copy link

Integration tests failure for e3352c2335e68cdb81c9692c0688cbf5822a19a0

@github-actions
Copy link

Integration tests failure for 759593f4f4e38bcbb7de1e61cfb381f6ff0d93c4

@github-actions
Copy link

Integration tests failure for 1ab5a97b13a7f57c7a43a500221afebc0c419d97

1 similar comment
@github-actions
Copy link

Integration tests failure for 1ab5a97b13a7f57c7a43a500221afebc0c419d97

@github-actions
Copy link

Integration tests failure for 31ba29ff6614a2cb7af6bac47c7aedb19fee1037

@github-actions
Copy link

Integration tests failure for 3acccbe66a24a203168d3736ab32cabf97f83bb3

@github-actions
Copy link

Integration tests failure for 0cadfa41eb75cd9563fe83d1276691dc7fcf8e8e

@github-actions
Copy link

Integration tests failure for 79fa28e7304536fe0f97b40b323609df369f0c06

@github-actions
Copy link

Integration tests failure for 004d145bbfbda97e14285c102d33db11cd28b32e

@alldoami alldoami changed the title [fix] Snowflake case sensitive names for TestAccExternalTable [fix] Removing broken test for external table Jan 26, 2021
@github-actions
Copy link

Integration tests success for a88b058c2362309f2b32d05bbaab7a4bb0404a5c

@github-actions
Copy link

Integration tests success for f21239396ac83dcc3fc9558e6bbb1f5969b49ad8

@alldoami alldoami merged commit be1c544 into main Jan 26, 2021
@alldoami alldoami deleted the adoami/ch67281/fix-bug-with-testaccexternaltable branch January 26, 2021 19:56
czimergebot pushed a commit that referenced this pull request Jan 26, 2021
When working on this PR: #426
I found that external stage and internal stage are slightly different, and should be tested.

Tests fail until the referenced PR is merged.
gjv9491 pushed a commit to gjv9491/terraform-provider-snowflake that referenced this pull request Mar 19, 2021
gjv9491 pushed a commit to gjv9491/terraform-provider-snowflake that referenced this pull request Mar 19, 2021
…lake-Labs#427)

When working on this PR: Snowflake-Labs#426
I found that external stage and internal stage are slightly different, and should be tested.

Tests fail until the referenced PR is merged.
anton-chekanov pushed a commit to anton-chekanov/terraform-provider-snowflake that referenced this pull request Jan 25, 2022
anton-chekanov pushed a commit to anton-chekanov/terraform-provider-snowflake that referenced this pull request Jan 25, 2022
…lake-Labs#427)

When working on this PR: Snowflake-Labs#426
I found that external stage and internal stage are slightly different, and should be tested.

Tests fail until the referenced PR is merged.
daniepett pushed a commit to daniepett/terraform-provider-snowflake that referenced this pull request Feb 9, 2022
daniepett pushed a commit to daniepett/terraform-provider-snowflake that referenced this pull request Feb 9, 2022
…lake-Labs#427)

When working on this PR: Snowflake-Labs#426
I found that external stage and internal stage are slightly different, and should be tested.

Tests fail until the referenced PR is merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants