-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Removing broken test for external table #426
[fix] Removing broken test for external table #426
Conversation
This pull request has been linked to Clubhouse Story #67281: Fix bug with TestAccExternalTable. |
Integration tests failure for 22f95b7e7f9600cc8d94867e5d998de63f8e4f48 |
Integration tests failure for dc537626a7d384cc13749d50dcc011c7632560ce |
Integration tests failure for e3352c2335e68cdb81c9692c0688cbf5822a19a0 |
1 similar comment
Integration tests failure for e3352c2335e68cdb81c9692c0688cbf5822a19a0 |
Integration tests failure for 759593f4f4e38bcbb7de1e61cfb381f6ff0d93c4 |
Integration tests failure for 1ab5a97b13a7f57c7a43a500221afebc0c419d97 |
1 similar comment
Integration tests failure for 1ab5a97b13a7f57c7a43a500221afebc0c419d97 |
Integration tests failure for 31ba29ff6614a2cb7af6bac47c7aedb19fee1037 |
Integration tests failure for 3acccbe66a24a203168d3736ab32cabf97f83bb3 |
Integration tests failure for 0cadfa41eb75cd9563fe83d1276691dc7fcf8e8e |
Integration tests failure for 79fa28e7304536fe0f97b40b323609df369f0c06 |
Integration tests failure for 004d145bbfbda97e14285c102d33db11cd28b32e |
Integration tests success for a88b058c2362309f2b32d05bbaab7a4bb0404a5c |
Integration tests success for f21239396ac83dcc3fc9558e6bbb1f5969b49ad8 |
When working on this PR: #426 I found that external stage and internal stage are slightly different, and should be tested. Tests fail until the referenced PR is merged.
…lake-Labs#427) When working on this PR: Snowflake-Labs#426 I found that external stage and internal stage are slightly different, and should be tested. Tests fail until the referenced PR is merged.
…lake-Labs#427) When working on this PR: Snowflake-Labs#426 I found that external stage and internal stage are slightly different, and should be tested. Tests fail until the referenced PR is merged.
…lake-Labs#427) When working on this PR: Snowflake-Labs#426 I found that external stage and internal stage are slightly different, and should be tested. Tests fail until the referenced PR is merged.
This was found my looking at
schema_acceptance_test.go
and seeing the diff since they should be similar acceptance tests. Snowflake is case sensitive and the error was looking for a case varying string when it was actually just all uppercase since we didn't encase the strings in double quotes.Error in tests:
diff:
jkdvwnnjek
andJKDVWNNJEK
Edit (1/26/2021): Removing this test because it is broken. We hit:
which is unclear what the real reason for the failure is but we're guessing that is has to do with not being able to create a fake s3 bucket for the external stage. If we still want to keep this test, the prior commits to the last one will still need to be considered.