Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] import and example for external table #415

Merged
merged 1 commit into from
Jan 27, 2021

Conversation

yohei1126
Copy link
Contributor

@yohei1126 yohei1126 commented Jan 18, 2021

document for external table resource is missing in the main branch.

Test Plan

  • acceptance tests

References

@yohei1126 yohei1126 requested a review from a team as a code owner January 18, 2021 12:59
@yohei1126 yohei1126 requested a review from ryanking January 18, 2021 12:59
@yohei1126 yohei1126 force-pushed the add-docs-external-table branch 2 times, most recently from 943edb7 to 23be3e4 Compare January 18, 2021 13:20
@yohei1126
Copy link
Contributor Author

@ryanking Would you check this? Thanks

@ryanking ryanking changed the title Add document for external table [docs] import and example for external table Jan 19, 2021
@ryanking
Copy link
Contributor

/ok-to-test sha=23be3e4

@github-actions
Copy link

Integration tests failure for 23be3e4

@yohei1126
Copy link
Contributor Author

@ryanking How can I check the failed test?

@ryanking
Copy link
Contributor

ryanking commented Jan 21, 2021

@yohei1126 when you click on the link (23be3e4) above does it take you to the tests?

@yohei1126
Copy link
Contributor Author

@ryanking I just added the document. I think main branch is broken?

=== RUN   TestAccExternalTable
    external_table_acceptance_test.go:14: Step 1/1 error: Error running apply: 2021/01/19 18:29:41 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0
        
        Error: error creating externalTable jkdvwnnjek: 002003 (02000): SQL compilation error:
        Database 'JKDVWNNJEK' does not exist or not authorized.

@ryanking
Copy link
Contributor

I think main branch is broken?

I don't see any failing tests on the main branch, but not sure what's going on here.

@yohei1126
Copy link
Contributor Author

#426 can fix the issue?

@alldoami
Copy link
Contributor

alldoami commented Jan 26, 2021

Hi @yohei1126 sorry to keep you waiting! Yup, we just had to skip that test temporarily. Should be good to go now. Could you fix the conflicts (keep your changes)? We can test again after.

@yohei1126 yohei1126 force-pushed the add-docs-external-table branch from 23be3e4 to 517def7 Compare January 27, 2021 00:31
@yohei1126
Copy link
Contributor Author

@alldoami done

@czimergebot czimergebot merged commit 40ac4c8 into Snowflake-Labs:main Jan 27, 2021
@yohei1126 yohei1126 deleted the add-docs-external-table branch January 27, 2021 00:41
gjv9491 pushed a commit to gjv9491/terraform-provider-snowflake that referenced this pull request Mar 19, 2021
document for external table resource is missing in the main branch.

<!-- summary of changes -->

## Test Plan
<!-- detail ways in which this PR has been tested or needs to be tested -->
* [x] acceptance tests
<!-- add more below if you think they are relevant -->
* [ ] …

## References
<!-- issues documentation links, etc  -->

*
anton-chekanov pushed a commit to anton-chekanov/terraform-provider-snowflake that referenced this pull request Jan 25, 2022
document for external table resource is missing in the main branch.

<!-- summary of changes -->

## Test Plan
<!-- detail ways in which this PR has been tested or needs to be tested -->
* [x] acceptance tests
<!-- add more below if you think they are relevant -->
* [ ] …

## References
<!-- issues documentation links, etc  -->

*
daniepett pushed a commit to daniepett/terraform-provider-snowflake that referenced this pull request Feb 9, 2022
document for external table resource is missing in the main branch.

<!-- summary of changes -->

## Test Plan
<!-- detail ways in which this PR has been tested or needs to be tested -->
* [x] acceptance tests
<!-- add more below if you think they are relevant -->
* [ ] …

## References
<!-- issues documentation links, etc  -->

*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants