Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Metric level fix with object renaming guide #3376

Merged
merged 5 commits into from
Feb 4, 2025
Merged

chore: Metric level fix with object renaming guide #3376

merged 5 commits into from
Feb 4, 2025

Conversation

sfc-gh-jcieslak
Copy link
Collaborator

Changes

@sfc-gh-jcieslak sfc-gh-jcieslak changed the base branch from main to dev February 4, 2025 12:26
@sfc-gh-jcieslak sfc-gh-jcieslak mentioned this pull request Feb 4, 2025
Closed
1 task
@sfc-gh-asawicki sfc-gh-asawicki self-requested a review February 4, 2025 12:30
sfc-gh-jmichalak
sfc-gh-jmichalak requested changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@sfc-gh-jmichalak sfc-gh-jmichalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also change L65 in docs/guides/identifiers_rework_design_decisions.md - from ../docs/resources/grant_privileges_to_account_role to ../resources/grant_privileges_to_account_role, thanks from the mountain

pkg/sdk/parameters.go
RequireStorageIntegrationForStageOperation *bool `ddl:"parameter" sql:"REQUIRE_STORAGE_INTEGRATION_FOR_STAGE_OPERATION"`
SSOLoginPage *bool `ddl:"parameter" sql:"SSO_LOGIN_PAGE"`
InitialReplicationSizeLimitInTB *string `ddl:"parameter" sql:"INITIAL_REPLICATION_SIZE_LIMIT_IN_TB"`
MetricLevel *MetricLevel `ddl:"parameter" sql:"METRIC_LEVEL"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be at user/session level? Similarly to LOG_LEVEL and TRACE_LEVEL.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's too much to change. I think we should address only the scope of the issue and tackle other parameters during the overall parameter rework/revisit.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this - we may note it down somewhere in jira.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added SNOW-1910853

docs/guides/object_renaming_guide.md Outdated Show resolved Hide resolved
@sfc-gh-jcieslak sfc-gh-jcieslak merged commit 629ff92 into dev Feb 4, 2025
8 of 9 checks passed
@sfc-gh-jcieslak sfc-gh-jcieslak deleted the metric-level-fix-with-object-renaming-guide branch February 4, 2025 13:05
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

Integration tests failure for 6dc7468e71a331f88c2470b311d8bd68935af3f9

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

Integration tests failure for 3815f127f2b5351f1ea15eee0a5c22fa3e4eada1

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

Integration tests failure for 2a980e9013325b3bf4414430e1338c07bae4d373

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

Integration tests failure for 8dc16e803eb7518f773b888cf34f6cc4b36f43ee

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

Integration tests failure for 488df0243f42a8c172cf8965b87f5c70080c6282

@snowflake-release-please snowflake-release-please bot mentioned this pull request Feb 5, 2025
Merged
sfc-gh-jcieslak pushed a commit that referenced this pull request Feb 5, 2025
@snowflake-release-please
chore(main): release 1.0.3 (#3380)
af5d1e4 
🤖 I have created a release *beep* *boop*
---


##
[1.0.3](v1.0.2...v1.0.3)
(2025-02-05)


### 🔧 **Misc**

* Add basic performance tests
([#3349](#3349))
([c57346b](c57346b))
* Add notes about managing grants on hybrid table
([#3368](#3368))
([e5e98bd](e5e98bd))
* Add preview and stable categories to resources and data sources in
docs
([#3370](#3370))
([b061434](b061434))
* Fix docs and update the protected users list
([#3365](#3365))
([f23e8cb](f23e8cb))
* Grant ownership common use cases
([#3356](#3356))
([97813b6](97813b6))
* Metric level fix with object renaming guide
([#3376](#3376))
([629ff92](629ff92))
* Move technical guides to the guide directory
([#3371](#3371))
([2b95809](2b95809))
* Prepare authentication methods guide
([#3364](#3364))
([c4a1c5f](c4a1c5f))
* Publish Performance tests summary
([#3359](#3359))
([d30d002](d30d002))
* Resolve issues and document account resource
([#3360](#3360))
([46b7a9d](46b7a9d))
* Upgrade tfplugindocs
([#3361](#3361))
([89f2b0a](89f2b0a))


### 🐛 **Bug fixes:**

* change EnforceNetworkRulesForInternalStages ddl to parameter
([#3343](#3343))
([beb01c7](beb01c7))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-asawicki sfc-gh-asawicki sfc-gh-asawicki approved these changes

@sfc-gh-jmichalak sfc-gh-jmichalak sfc-gh-jmichalak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-jcieslak @sfc-gh-asawicki @sfc-gh-jmichalak