-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add basic performance tests #3349
Conversation
12dbc35
to
471ca8e
Compare
Integration tests cancelled for df6352f2d88fed002ca7468393997ead329f8b8d |
type = number | ||
} | ||
|
||
terraform { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this block required in every module? (or can it be only present in the main config?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
# Basic standalone task | ||
resource "snowflake_task" "task" { | ||
database = snowflake_database.database[0].name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be sure, when var.resource_count == 0
this is not evaluated and not throwing any warning/error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's working correctly because the list of tasks is empty, and this line is not evaluated.
Integration tests failure for 471ca8e6774acf9bd2d76ab0700d91b4bc10a394 |
Integration tests failure for 12dbc35f88ec107cce98b2f5d0263d9e2f20373b |
Integration tests cancelled for 5067491fe19200600d3c5a547bfae8b1d1cb2786 |
Test Plan
References
#3118
#3169
TODO