Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add basic performance tests #3349

Merged
merged 5 commits into from
Jan 24, 2025
Merged

chore: Add basic performance tests #3349

merged 5 commits into from
Jan 24, 2025

Conversation

sfc-gh-jmichalak
Copy link
Collaborator

@sfc-gh-jmichalak sfc-gh-jmichalak commented Jan 21, 2025

  • Add basic performance tests in the manual tests package.
  • Include a tf lock file in gitignore.
  • Update the state of resource rework.

Test Plan

  • acceptance tests

References

#3118
#3169

TODO

  • Publish the summary document.

@sfc-gh-jmichalak sfc-gh-jmichalak changed the base branch from main to dev January 21, 2025 09:49
Copy link

Integration tests cancelled for df6352f2d88fed002ca7468393997ead329f8b8d

type = number
}

terraform {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this block required in every module? (or can it be only present in the main config?)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


# Basic standalone task
resource "snowflake_task" "task" {
database = snowflake_database.database[0].name
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be sure, when var.resource_count == 0 this is not evaluated and not throwing any warning/error

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working correctly because the list of tasks is empty, and this line is not evaluated.

Copy link

Integration tests failure for 471ca8e6774acf9bd2d76ab0700d91b4bc10a394

Copy link

Integration tests failure for 12dbc35f88ec107cce98b2f5d0263d9e2f20373b

pkg/manual_tests/benchmarks/README.md Outdated Show resolved Hide resolved
pkg/manual_tests/benchmarks/README.md Outdated Show resolved Hide resolved
Copy link

Integration tests cancelled for 5067491fe19200600d3c5a547bfae8b1d1cb2786

@sfc-gh-asawicki sfc-gh-asawicki self-requested a review January 24, 2025 10:25
@sfc-gh-jmichalak sfc-gh-jmichalak merged commit c57346b into dev Jan 24, 2025
9 of 10 checks passed
@sfc-gh-jmichalak sfc-gh-jmichalak deleted the performance-tests branch January 24, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants