feat: Connection resource

docs/resources/connection.md → docs/resources/primary_connection.md

@@ -1,26 +1,26 @@
 ---
-page_title: "snowflake_connection Resource - terraform-provider-snowflake"
+page_title: "snowflake_primary_connection Resource - terraform-provider-snowflake"
 subcategory: ""
 description: |-
   Resource used to manage primary (not replicated) connections. For more information, check connection documentation https://docs.snowflake.com/en/sql-reference/sql/create-connection.html.
 ---
 
 !> **V1 release candidate** This resource is a release candidate for the V1. It is on the list of remaining GA objects for V1. We do not expect significant changes in it before the V1. We will welcome any feedback and adjust the resource if needed. Any errors reported will be resolved with a higher priority. We encourage checking this resource out before the V1 release. Please follow the [migration guide](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/MIGRATION_GUIDE.md#v0970--v0980) to use it.
 
-# snowflake_connection (Resource)
+# snowflake_primary_connection (Resource)
 
 Resource used to manage primary (not replicated) connections. For more information, check [connection documentation](https://docs.snowflake.com/en/sql-reference/sql/create-connection.html).
 
 ## Example Usage
 
 ```terraform
 ## Minimal
-resource "snowflake_connection" "basic" {
+resource "snowflake_primary_connection" "basic" {
   name = "connection_name"
 }
 
 ## Complete (with every optional set)
-resource "snowflake_connection" "complete" {
+resource "snowflake_primary_connection" "complete" {
   name    = "connection_name"
   comment = "my complete connection"
   enable_failover_to_accounts = [
@@ -47,7 +47,7 @@ resource "snowflake_connection" "complete" {
 
 - `fully_qualified_name` (String) Fully qualified name of the resource. For more information, see [object name resolution](https://docs.snowflake.com/en/sql-reference/name-resolution).
 - `id` (String) The ID of this resource.
-- `show_output` (List of Object) Outputs the result of `SHOW CONNECTIONS` for the given secret. (see [below for nested schema](#nestedatt--show_output))
+- `show_output` (List of Object) Outputs the result of `SHOW CONNECTIONS` for the given connection. (see [below for nested schema](#nestedatt--show_output))
 
 <a id="nestedatt--show_output"></a>
 ### Nested Schema for `show_output`
@@ -72,5 +72,5 @@ Read-Only:
 Import is supported using the following syntax:
 
 ```shell
-terraform import snowflake_connection.example 'connection_name'
+terraform import snowflake_primary_connection.example 'connection_name'
 ```

docs/resources/secondary_connection.md

@@ -2,21 +2,22 @@
 page_title: "snowflake_secondary_connection Resource - terraform-provider-snowflake"
 subcategory: ""
 description: |-
-  Resource used to manage secondary connections. For more information, check connection documentation https://docs.snowflake.com/en/sql-reference/sql/create-connection.html.
+  Resource used to manage secondary connections. To promote secondary connection to primary check migraton guide https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/MIGRATION_GUIDE.md#connection-resources. For more information, check connection documentation https://docs.snowflake.com/en/sql-reference/sql/create-connection.html.
 ---
 
 !> **V1 release candidate** This resource is a release candidate for the V1. It is on the list of remaining GA objects for V1. We do not expect significant changes in it before the V1. We will welcome any feedback and adjust the resource if needed. Any errors reported will be resolved with a higher priority. We encourage checking this resource out before the V1 release. Please follow the [migration guide](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/MIGRATION_GUIDE.md#v0970--v0980) to use it.
 
 # snowflake_secondary_connection (Resource)
 
-Resource used to manage secondary connections. For more information, check [connection documentation](https://docs.snowflake.com/en/sql-reference/sql/create-connection.html).
+Resource used to manage secondary connections. To promote secondary connection to primary check [migraton guide](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/MIGRATION_GUIDE.md#connection-resources). For more information, check [connection documentation](https://docs.snowflake.com/en/sql-reference/sql/create-connection.html).
 
 ## Example Usage
 
 ```terraform
 ## Minimal
 resource "snowflake_secondary_connection" "basic" {
-  name = "connection_name"
+  name          = "connection_name"
+  as_replica_of = "<organization_name>.<account_name>.<connection_name>"
 }
 
 ## Complete (with every optional set)
@@ -46,7 +47,7 @@ resource "snowflake_secondary_connection" "complete" {
 - `fully_qualified_name` (String) Fully qualified name of the resource. For more information, see [object name resolution](https://docs.snowflake.com/en/sql-reference/name-resolution).
 - `id` (String) The ID of this resource.
 - `is_primary` (Boolean) Indicates if the connection has been changed to primary. If change is detected, the secondary connection will be recreated.
-- `show_output` (List of Object) Outputs the result of `SHOW CONNECTIONS` for the given secret. (see [below for nested schema](#nestedatt--show_output))
+- `show_output` (List of Object) Outputs the result of `SHOW CONNECTIONS` for the given connection. (see [below for nested schema](#nestedatt--show_output))
 
 <a id="nestedatt--show_output"></a>
 ### Nested Schema for `show_output`

examples/resources/snowflake_primary_connection/import.sh

@@ -0,0 +1 @@
+terraform import snowflake_primary_connection.example 'connection_name'

examples/resources/snowflake_connection/resource.tf → examples/resources/snowflake_primary_connection/resource.tf

@@ -1,10 +1,10 @@
 ## Minimal
-resource "snowflake_connection" "basic" {
+resource "snowflake_primary_connection" "basic" {
   name = "connection_name"
 }
 
 ## Complete (with every optional set)
-resource "snowflake_connection" "complete" {
+resource "snowflake_primary_connection" "complete" {
   name    = "connection_name"
   comment = "my complete connection"
   enable_failover_to_accounts = [

examples/resources/snowflake_secondary_connection/resource.tf

@@ -1,6 +1,7 @@
 ## Minimal
 resource "snowflake_secondary_connection" "basic" {
-  name = "connection_name"
+  name          = "connection_name"
+  as_replica_of = "<organization_name>.<account_name>.<connection_name>"
 }
 
 ## Complete (with every optional set)

pkg/acceptance/bettertestspoc/assert/resourceassert/gen/resource_schema_def.go

@@ -98,8 +98,8 @@ var allResourceSchemaDefs = []ResourceSchemaDef{
 		schema: resources.StreamOnView().Schema,
 	},
 	{
-		name:   "Connection",
-		schema: resources.Connection().Schema,
+		name:   "PrimaryConnection",
+		schema: resources.PrimaryConnection().Schema,
 	},
 	{
 		name:   "SecondaryConnection",

pkg/acceptance/bettertestspoc/assert/resourceassert/connection_resource_ext.go → pkg/acceptance/bettertestspoc/assert/resourceassert/primary_connection_resource_ext.go

@@ -7,23 +7,15 @@ import (
 	"github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/sdk"
 )
 
-/*
-func (c *ConnectionResourceAssert) HasAsReplicaOfIdentifier(expected sdk.ExternalObjectIdentifier) *ConnectionResourceAssert {
-	expectedString := strings.ReplaceAll(expected.FullyQualifiedName(), `"`, "")
-	c.AddAssertion(assert.ValueSet("as_replica_of", expectedString))
-	return c
-}
-*/
-
-func (c *ConnectionResourceAssert) HasEnableFailoverToAccounts(expected ...sdk.AccountIdentifier) *ConnectionResourceAssert {
+func (c *PrimaryConnectionResourceAssert) HasExactlyFailoverToAccountsInOrder(expected ...sdk.AccountIdentifier) *PrimaryConnectionResourceAssert {
 	c.AddAssertion(assert.ValueSet("enable_failover_to_accounts.#", fmt.Sprintf("%d", len(expected))))
 	for i, v := range expected {
 		c.AddAssertion(assert.ValueSet(fmt.Sprintf("enable_failover_to_accounts.%d", i), v.Name()))
 	}
 	return c
 }
 
-func (c *ConnectionResourceAssert) HasNoEnableFailoverToAccounts() *ConnectionResourceAssert {
+func (c *PrimaryConnectionResourceAssert) HasNoEnableFailoverToAccounts() *PrimaryConnectionResourceAssert {
 	c.AddAssertion(assert.ValueSet("enable_failover_to_accounts.#", "0"))
 	return c
 }

pkg/acceptance/bettertestspoc/assert/resourceshowoutputassert/connection_show_output_ext.go

@@ -8,8 +8,7 @@ import (
 )
 
 func (c *ConnectionShowOutputAssert) HasPrimaryIdentifier(expected sdk.ExternalObjectIdentifier) *ConnectionShowOutputAssert {
-	// expectedString := strings.ReplaceAll(expected.FullyQualifiedName(), `"`, "")
-	c.AddAssertion(assert.ResourceShowOutputValueSet("primary", expected.Name()))
+	c.AddAssertion(assert.ResourceShowOutputValueSet("primary", expected.FullyQualifiedName()))
 	return c
 }