feat: Connection resource #3162

sfc-gh-fbudzynski · 2024-10-29T13:06:45Z

Changes

connection resource
connection documentation
added connection to migration guide

Test Plan

acceptance tests

TODO

References

…nowflake into connection-sdk

…nowflake into connection-resource

MIGRATION_GUIDE.md

docs/resources/connection.md

pkg/acceptance/bettertestspoc/assert/resourceassert/connection_resource_ext.go

pkg/acceptance/bettertestspoc/assert/resourceshowoutputassert/connection_show_output_ext.go

pkg/acceptance/bettertestspoc/config/model/connection_model_ext.go

pkg/resources/connection.go

pkg/resources/connection_acceptance_test.go

github-actions · 2024-10-30T10:14:31Z

Integration tests success for 9becdb93a39fbcdf01c0293eef45adbe3992ef85

github-actions · 2024-10-31T18:37:08Z

Integration tests failure for 9ed9076c0d3be5ec5f3154b9bed97a73b785c905

MIGRATION_GUIDE.md

docs/resources/secondary_connection.md

pkg/acceptance/bettertestspoc/assert/resourceassert/connection_resource_ext.go

pkg/acceptance/bettertestspoc/assert/resourceshowoutputassert/connection_show_output_ext.go

pkg/resources/connection.go

pkg/resources/secondary_connection.go

pkg/sdk/connections_gen_test.go

pkg/sdk/connections_impl_gen.go

pkg/resources/connection.go

pkg/resources/secondary_connection.go

pkg/sdk/connections_impl_gen.go

pkg/resources/secondary_connection.go

pkg/provider/resources/resources.go

github-actions · 2024-11-04T18:32:33Z

Integration tests success for f86d26e1fed91cf49852de03060872a21a6c4b04

…nowflake into connection-resource

sfc-gh-asawicki

For me, all the nits and comments (from my review) can be handled in the next separate PR

sfc-gh-asawicki · 2024-11-05T12:26:53Z

MIGRATION_GUIDE.md

+
+Added a new resources for managing connections. We decided to split connection into two separate resources based on whether the connection is primary or a replica (secondary). i.e.:
+
+- `snowflake_connection` is used as primary connection, with ability to enable failover to other accounts.


nit: snowflake_primary_connection

sfc-gh-asawicki · 2024-11-05T12:28:13Z

MIGRATION_GUIDE.md

+- `snowflake_connection` is used as primary connection, with ability to enable failover to other accounts.
+- `snowflake_secondary_connection` is used as replica (secondary) connection.
+
+In order to promote secondary_connection to primary, resources need to be migrated (check [resource migration](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/docs/technical-documentation/resource_migration.md)) or re-created and imported using the following SQL statements on Snowflake Worksheet:


nit: this is fine to have this info in the migration guide, but eventually, it would be great to also include this in the resource docs (it's important information for later)

pkg/acceptance/bettertestspoc/assert/objectassert/connection_snowflake_gen.go

sfc-gh-asawicki · 2024-11-05T12:31:00Z

pkg/resources/custom_diffs.go

+// TODO: [SNOW-1763442] unable to test now, as there is no test accounts with different regions
+// RecreateWhenSecondaryConnectionChangedExternally detects if the secondary connection was promoted externally to serve as primary.
+// If so, it sets the `is_primary` field to `false` which is our desired value for secondary_connection
+func RecreateWhenSecondaryConnectionPromotedExternally() schema.CustomizeDiffFunc {


nit: we have to handle this the other way around too for primary connection demotion

sfc-gh-asawicki · 2024-11-05T12:31:12Z

pkg/resources/custom_diffs_test.go

@@ -2,11 +2,10 @@ package resources_test

 import (
 	"context"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/customdiff"


nit: imports ordering

sfc-gh-asawicki · 2024-11-05T12:33:25Z

pkg/resources/custom_diffs.go

+func RecreateWhenSecondaryConnectionPromotedExternally() schema.CustomizeDiffFunc {
+	return func(_ context.Context, diff *schema.ResourceDiff, _ any) error {
+		if _, newValue := diff.GetChange("is_primary"); newValue.(bool) {
+			return diff.SetNew("is_primary", false)


hmmm, this logic is not aligned with others (check RecreateWhenUserTypeChangedExternally, RecreateWhenSecretTypeChangedExternally, or RecreateWhenResourceTypeChangedExternally) - there is ForceNew missing - it's a problem but it can be handled in the next PR too

sfc-gh-asawicki · 2024-11-05T12:35:17Z

pkg/resources/primary_connection_acceptance_test.go

+func TestAcc_PrimaryConnection_Basic(t *testing.T) {
+	// TODO: [SNOW-1002023]: Unskip; Business Critical Snowflake Edition needed
+	_ = testenvs.GetOrSkipTest(t, testenvs.TestFailoverGroups)
+


nit: add

_ = testenvs.GetOrSkipTest(t, testenvs.EnableAcceptance) acc.TestAccPreCheck(t)

to all the tests that use TestClient in their set-up

pkg/sdk/parsers.go

pkg/resources/secondary_connection.go

sfc-gh-jcieslak

Approved. There are still open threads and new comments that are not crucial and can be applied in the next pr.

sfc-gh-jcieslak · 2024-11-05T12:24:14Z

MIGRATION_GUIDE.md

+- `snowflake_connection` is used as primary connection, with ability to enable failover to other accounts.
+- `snowflake_secondary_connection` is used as replica (secondary) connection.
+
+In order to promote secondary_connection to primary, resources need to be migrated (check [resource migration](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/docs/technical-documentation/resource_migration.md)) or re-created and imported using the following SQL statements on Snowflake Worksheet:


This is good, but slightly rephrase that In order to promote secondary_connection to primary, resources need to be removed from the state, re-created manually using the following SQL statements ... then imported again, but now as snowflake_connection (check resource migration).

pkg/resources/custom_diffs_test.go

pkg/schemas/connection_gen.go

pkg/resources/connection.go

github-actions · 2024-11-05T14:18:58Z

Integration tests failure for e779da4cdcae7f1e10dbc1644b0e1111008bbc21

github-actions · 2024-11-05T14:34:13Z

Integration tests failure for 1263a916756ab874a764f57e965e2d69288b3e31

## Changes * fix secrets datasource acceptance tests * added tests for `ParseCommaSeparatedAccountIdentifierArray` * added customDiff and tests for re-creating connection resources * adjusted migration-guide and documentation for connection resources * added 'TestAccPreCheck' to acceptance tests ## Test Plan  * [x] unit tests * [x] integration tests * [x] acceptance tests * [x] acceptance tests for secrets-datasource ## References  * #3162 --------- Co-authored-by: Jan Cieślak <[email protected]>

## [0.98.0](v0.97.0...v0.98.0) (2024-11-08) Feature scope readiness for V1: [link](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/v1-preparations/ESSENTIAL_GA_OBJECTS.MD) ([Roadmap reference](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/ROADMAP.md#wrap-up-the-functional-scope)). :exclamation: Migration guide: [v0.97.0 -> v0.98.0](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/MIGRATION_GUIDE.md#v0970--v0980) ### 🎉 What's new - New resources: - authentication_policy ([#3098](#3098)), references [#2880](#2880) - external_volume ([#3106](#3106)), partially references [#2980](#2980) - stream_on_directory_table ([#3129](#3129)) - stream_on_view ([#3150](#3150)) - primary_connection, secondary_connection ([#3162](#3162)) - secret_with_basic_authentication, secret_with_generic_string, secret_with_oauth_authorization_code_grant, secret_with_oauth_client_credentials ([#3110](#3110)), ([#3141](#3141)) - New data sources: - connections ([#3155](#3155)), ([#3173](#3173)) - secrets ([#3131](#3131)) - Reworked: - provider configuration hierarchy ([#3166](#3166)), references [#1881](#1881), [#2145](#2145), [#2925](#2925), [#2983](#2983), [#3104](#3104) - provider configuration fields ([#3152](#3152)) streams data source ([#3151](#3151)) - SDK upgrades: - Upgrade tag SDK ([#3126](#3126)) - Recreate streams when they are stale ([#3129](#3129)) ### 🔧 Misc - Add object renaming research summary ([#3172](#3172)) - Test support for object renaming ([#3130](#3130)), ([#3147](#3147)), ([#3154](#3154)) - Add tests to issue [#3117](#3117) ([#3133](#3133)) - New roadmap entry ([#3158](#3158)) - Test more authentication methods ([#3178](#3178)) - Minor fixes ([#3174](#3174)) ### 🐛 Bug fixes - Apply various fixes ([#3176](#3176)), this addresses BCR 2024_08, references [#2717](#2717), [#3005](#3005), [#3125](#3125), [#3127](#3127), [#3153](#3153) - Connection and secret data sources tests ([#3177](#3177)) - Fix grant import docs ([#3183](#3183)), resolves [#3179](https://github.com/Snowflake-Labs/terraform-provider-snowflake/discussions/3179) - Fix user resource import ([#3181](#3181)) - Handle external type changes in stream resources ([#3164](#3164)) - Do not use OR REPLACE on initial creation in resources with copy_grants ([#3129](#3129)) - Address issue [#2201](#2201) by introducing new stream resources Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>

sfc-gh-fbudzynski added 30 commits October 18, 2024 17:28

initial commit for connections sdk

c321654

added show and drop

6b989e3

connection assert generated

fb8d018

assertions generated

6db06d8

integration test

24a2c80

before self-review

5c8f84f

integration tests

a5d59b6

simplified disable connection failover struct

f831c02

Merge branch 'main' of github.com:Snowflake-Labs/terraform-provider-s…

fa3db2b

…nowflake into connection-sdk

init resource for connections

e140406

Merge branch 'main' of github.com:Snowflake-Labs/terraform-provider-s…

fc4cd95

…nowflake into connection-sdk

adjusted to comments from review

1dee95b

Merge branch 'connection-sdk' into connection-resource

f0915c4

create for connection resource

5291ab3

merge conflict with main resolved

a6668d9

linter adjustemnts

f8c64f7

pre-push adjustment

68fce3d

Merge branch 'main' of github.com:Snowflake-Labs/terraform-provider-s…

661a8a4

…nowflake into connection-sdk

resource CRUD functions

993da0d

Merge branch 'main' of github.com:Snowflake-Labs/terraform-provider-s…

7197faa

…nowflake into connection-sdk

added drop with if exists and HasPrimaryIdentifier extended function

fd52498

pre-push adjustments

b739e99

added skips for tests

d7b13de

acceptance tests for connection

147f85a

Merge branch 'main' of github.com:Snowflake-Labs/terraform-provider-s…

5394364

…nowflake into connection-resource

with exists to connection resource delete

fb3d563

resolved comments

f9c4f6a

Merge branch 'connection-sdk' into connection-resource

e665b38

connection resource with docs and migration guide

44c1c05

pre-push adjustments

215d6af

sfc-gh-jcieslak reviewed Oct 30, 2024

View reviewed changes

sfc-gh-fbudzynski added 8 commits October 30, 2024 15:37

before discussing whether to split resource

ffe98a1

rename unset and set to unsetConnection and setConnection

958a596

rename unset and set in tests

284e920

seperate connection resource to primary and secondary

8ced116

linter adjustemnts

dc08d74

secondary connection custom diff

ca44fcb

pre-push adjustments

47edb32

merge request resolved

9ed9076

sfc-gh-jcieslak reviewed Nov 4, 2024

View reviewed changes

sfc-gh-jmichalak reviewed Nov 4, 2024

View reviewed changes

sfc-gh-fbudzynski added 2 commits November 4, 2024 16:04

changed naming of primary connection, and adjusted to comments in pr

4efce94

added docs

f86d26e

sfc-gh-fbudzynski added 3 commits November 5, 2024 12:16

Merge branch 'main' of github.com:Snowflake-Labs/terraform-provider-s…

dcc24e0

…nowflake into connection-resource

custom diff for secondary_connection

e779da4

Merge branch 'main' of github.com:Snowflake-Labs/terraform-provider-s…

1263a91

…nowflake into connection-resource

sfc-gh-asawicki approved these changes Nov 5, 2024

View reviewed changes

sfc-gh-jmichalak approved these changes Nov 5, 2024

View reviewed changes

pkg/resources/secondary_connection.go Show resolved Hide resolved

sfc-gh-jcieslak approved these changes Nov 5, 2024

View reviewed changes

sfc-gh-fbudzynski merged commit 5aef117 into main Nov 7, 2024
8 of 9 checks passed

sfc-gh-fbudzynski deleted the connection-resource branch November 7, 2024 08:40

snowflake-release-please bot mentioned this pull request Nov 7, 2024

chore(main): release 0.98.0 #3137

Merged

sfc-gh-fbudzynski mentioned this pull request Nov 7, 2024

fix: Connection and secret-datasource tests #3177

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Connection resource #3162

feat: Connection resource #3162

sfc-gh-fbudzynski commented Oct 29, 2024 •

edited

Loading

github-actions bot commented Oct 30, 2024

github-actions bot commented Oct 31, 2024

github-actions bot commented Nov 4, 2024

sfc-gh-asawicki left a comment

sfc-gh-asawicki Nov 5, 2024

sfc-gh-asawicki Nov 5, 2024

sfc-gh-asawicki Nov 5, 2024

sfc-gh-asawicki Nov 5, 2024

sfc-gh-asawicki Nov 5, 2024

sfc-gh-asawicki Nov 5, 2024

sfc-gh-jcieslak left a comment

sfc-gh-jcieslak Nov 5, 2024

github-actions bot commented Nov 5, 2024

github-actions bot commented Nov 5, 2024


		Added a new resources for managing connections. We decided to split connection into two separate resources based on whether the connection is primary or a replica (secondary). i.e.:

		- `snowflake_connection` is used as primary connection, with ability to enable failover to other accounts.

feat: Connection resource #3162

feat: Connection resource #3162

Conversation

sfc-gh-fbudzynski commented Oct 29, 2024 • edited Loading

Changes

Test Plan

TODO

References

github-actions bot commented Oct 30, 2024

github-actions bot commented Oct 31, 2024

github-actions bot commented Nov 4, 2024

sfc-gh-asawicki left a comment

Choose a reason for hiding this comment

sfc-gh-asawicki Nov 5, 2024

Choose a reason for hiding this comment

sfc-gh-asawicki Nov 5, 2024

Choose a reason for hiding this comment

sfc-gh-asawicki Nov 5, 2024

Choose a reason for hiding this comment

sfc-gh-asawicki Nov 5, 2024

Choose a reason for hiding this comment

sfc-gh-asawicki Nov 5, 2024

Choose a reason for hiding this comment

sfc-gh-asawicki Nov 5, 2024

Choose a reason for hiding this comment

sfc-gh-jcieslak left a comment

Choose a reason for hiding this comment

sfc-gh-jcieslak Nov 5, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 5, 2024

github-actions bot commented Nov 5, 2024

sfc-gh-fbudzynski commented Oct 29, 2024 •

edited

Loading