Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: grant ownership on tasks #2684

Merged
merged 15 commits into from
Apr 9, 2024
Merged

Conversation

sfc-gh-jcieslak
Copy link
Collaborator

@sfc-gh-jcieslak sfc-gh-jcieslak commented Apr 8, 2024

Changes:

  • The follow-up grant ownership PR adds support to grant ownership on Tasks.
  • Add a reminder to the documentation to always copy the state file before applying any state-manipulating functions.
  • Added GrantOptionFor option during revoke in privilege-granting resources, so only with_grant_option will be removed instead of the whole grant, making the process less destructive

Test Plan

  • acceptance tests
  • integration tests

References

changes after review

wip

wip

wip

wip

Adjust grant ownership on pipe to be less hacky without any additional grants underneath

fixes after review

fixes after review

fixes after review

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip
@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the grant-ownership-on-tasks branch from 5bd2d11 to 8901124 Compare April 8, 2024 10:50
Copy link

github-actions bot commented Apr 8, 2024

Integration tests failure for 5bd2d114e408d1800a6abf7da4297fd2bf841775

Copy link

github-actions bot commented Apr 8, 2024

Integration tests failure for 89011240839e3669a2b038333dd29f6bd0c4cf73

Copy link

github-actions bot commented Apr 8, 2024

Integration tests failure for 8258edef4c7acf95fcfa5446f0b3493b56895f30

@sfc-gh-asawicki sfc-gh-asawicki self-requested a review April 8, 2024 13:49
Copy link

github-actions bot commented Apr 8, 2024

Integration tests failure for 5235ee61b7680d7e4728f9125ee16275b8abc443

docs/resources/grant_ownership.md Outdated Show resolved Hide resolved
docs/resources/grant_ownership.md Outdated Show resolved Hide resolved
pkg/sdk/grants_impl.go Outdated Show resolved Hide resolved
pkg/sdk/grants_impl.go Outdated Show resolved Hide resolved
# Conflicts:
#	docs/resources/grant_ownership.md
#	templates/resources/grant_ownership.md.tmpl
@sfc-gh-asawicki sfc-gh-asawicki self-requested a review April 8, 2024 15:03
sfc-gh-asawicki
sfc-gh-asawicki previously approved these changes Apr 8, 2024
Copy link

github-actions bot commented Apr 8, 2024

Integration tests failure for 925075bada260c9b2edbdeb5987a8f31ef466e5c

Copy link

github-actions bot commented Apr 8, 2024

Integration tests failure for 3022e79af0e416a2498314fe3ae76f5c22ed5472

1 similar comment
Copy link

github-actions bot commented Apr 9, 2024

Integration tests failure for 3022e79af0e416a2498314fe3ae76f5c22ed5472

Copy link

github-actions bot commented Apr 9, 2024

Integration tests failure for f27da54fb7aafdf04842410eeb5d71d7ae4bc187

@sfc-gh-jcieslak sfc-gh-jcieslak merged commit 2ba7889 into main Apr 9, 2024
8 of 9 checks passed
@sfc-gh-jcieslak sfc-gh-jcieslak deleted the grant-ownership-on-tasks branch April 9, 2024 09:55
sfc-gh-jcieslak pushed a commit that referenced this pull request Apr 9, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.88.0](v0.87.3-pre...v0.88.0)
(2024-04-09)


### 🎉 **What's new:**

* Fix issues 2651 2656
([#2659](#2659))
([7fa09cc](7fa09cc))
* Grant ownership follow up
([#2628](#2628))
([d467e5b](d467e5b))
* grant ownership follow-up
([#2658](#2658))
([bfa2317](bfa2317))
* grant ownership on tasks
([#2684](#2684))
([2ba7889](2ba7889))
* Introduce shared function to suspend task roots
([#2650](#2650))
([d684b5d](d684b5d))
* Redesign snowflake_grants datasource
([#2667](#2667))
([918873d](918873d))
* user password policy attachment
([#2627](#2627))
([382e49d](382e49d))


### 🔧 **Misc**

* release 0.88.0
([02d60e0](02d60e0))
* Update grant examples in all resources
([#2660](#2660))
([b542b69](b542b69))


### 🐛 **Bug fixes:**

* Adjust dynamic tables after BCR-1543
([#2664](#2664))
([cf32ceb](cf32ceb))
* Fix handling secure views read and import
([#2655](#2655))
([3c3ede6](3c3ede6))
* Fix issues 2606 2642 2652 2653
([#2654](#2654))
([4a73721](4a73721))
* Fix release workflow
([#2639](#2639))
([dfd07e9](dfd07e9))
* Generate docs for dynamic table
([#2666](#2666))
([16c75b0](16c75b0))
* grant read operation
([#2665](#2665))
([0b947a5](0b947a5))
* migration guide for databases created from share
([#2637](#2637))
([f9651bc](f9651bc))
* with_grant_option diff drift
([#2608](#2608))
([f0018c6](f0018c6))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants