feat: Grant ownership follow up tasks [FOR LATER] #2670
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration tests failure for bbb917b105b7e49c162017b157621841e73eb1b6 |
sfc-gh-jcieslak
force-pushed
the
grant-ownership-follow-up-tasks
branch
from
bbb917b to
eac42cc
Compare
|
Integration tests failure for eac42cc69d65b2178abd8e44d293fdeeeb102cb6 |
|
Integration tests failure for 1448561dee41f83dae334d7260b2cd931eb55be5 |
2 tasks
sfc-gh-jcieslak
changed the title
sfc-gh-jcieslak
force-pushed
the
grant-ownership-follow-up-tasks
branch
from
1448561 to
3cf9e9c
Compare
|
Integration tests failure for 3cf9e9c89ad668bc3d216468da192080de29ed7e |
|
Integration tests failure for 85f09f56cdc4f476f50652b03180e451999a62fc |
sfc-gh-jcieslak
added a commit
that referenced
this pull request
Apr 9, 2024
Changes: - The follow-up grant ownership PR adds support to grant ownership on Tasks. - Add a reminder to the documentation to always copy the state file before applying any state-manipulating functions. - Added GrantOptionFor option during revoke in privilege-granting resources, so only with_grant_option will be removed instead of the whole grant, making the process less destructive ## Test Plan <!-- detail ways in which this PR has been tested or needs to be tested --> * [x] acceptance tests * [x] integration tests ## References * #2670 Another solution for granting ownership `on all tasks` - to be considered in the future. * [Grant Ownership](https://docs.snowflake.com/en/sql-reference/sql/grant-ownership)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add handling of the grant ownership on tasks.
The second solution that almost enables us to provide automatic suspend/resume of tasks during grant ownership. This solution, instead of calling
grant on all tasksis callingshow tasksand going through every task one by one.The current solution could be better if we could use
grant on all tasksand resume tasks that were suspended bygrant ownershipcall. This "may" be possible by utilizinglast_suspend_reason_field returned bySHOW TASKS.