fix: unset network policy should not have single quotes #2584
Conversation
There was a problem hiding this comment.
Hey @raulbonet. Thanks for another contribution! I have just left cosmetic remarks, I hope that's okay. :)
|
Hey @raulbonet. Did you have a chance to introduce the changes after the review? Maybe we can help you and hijack the PR? cc: @sfc-gh-jcieslak |
|
Hello @sfc-gh-asawicki Sorry for the delay, I got pulled into another project. I can do this tomorrow :) |
|
/ok-to-test sha=1767e034edbf312453e6f4781acd1fd522181893 |
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 10577203 | Triggered | Snowflake Credentials | 1767e03 | test.env.example | View secret |
| 9467623 | Triggered | Generic Password | 1767e03 | pkg/resources/password_policy_acceptance_test.go | View secret |
| 9467623 | Triggered | Generic Password | 1767e03 | pkg/resources/password_policy_acceptance_test.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
Integration tests failure for 1767e034edbf312453e6f4781acd1fd522181893 |
|
Hi @sfc-gh-asawicki |
|
/ok-to-test sha=5f72418cc5e1e8c32cf2b859917592e47bd724b0 |
|
Integration tests failure for 5f72418cc5e1e8c32cf2b859917592e47bd724b0 |
1 similar comment
|
Integration tests failure for 5f72418cc5e1e8c32cf2b859917592e47bd724b0 |
|
@raulbonet merged, thank you for another contribution! :) |
🤖 I have created a release *beep* *boop* --- ## [0.90.0](v0.89.0...v0.90.0) (2024-05-08) ### 🎉 **What's new:** * Adjust owner_role_type and schema_evolution_record columns ([#2740](#2740)) ([424e393](424e393)) ### 🔧 **Misc** * Add a guide on creating issues ([#2758](#2758)) ([2b006aa](2b006aa)) * Add missing documentation ([#2781](#2781)) ([cc0a6a7](cc0a6a7)) * Add scripts to close issues from Pre Snowflake bucket ([#2762](#2762)) ([44c0c37](44c0c37)) * Add small adjustments ([#2783](#2783)) ([e5b0b4b](e5b0b4b)) * Adjust issue templates ([#2748](#2748)) ([64ab76d](64ab76d)) * Cleanup helpers part 3 ([#2730](#2730)) ([eb7bee4](eb7bee4)) * Cleanup helpers part 5 ([#2744](#2744)) ([1f165bf](1f165bf)) * Cleanup helpers part4 ([#2741](#2741)) ([9475e35](9475e35)) * Cleanup helpers part6 ([#2745](#2745)) ([eba3029](eba3029)) * Cleanup helpers poc ([#2724](#2724)) ([70b99fb](70b99fb)) * Helpers cleanup continuation ([#2726](#2726)) ([a70d1af](a70d1af)) * Prepare new roadmap entry ([#2773](#2773)) ([b0bf28f](b0bf28f)) * Prepare parallel builds ([#2737](#2737)) ([6974e25](6974e25)) * Update the contribution guidelines (and small fixes) ([#2753](#2753)) ([aafdc72](aafdc72)) ### 🐛 **Bug fixes:** * Fix issue templates ([#2760](#2760)) ([d0d5048](d0d5048)) * Fix setup for two tests ([#2757](#2757)) ([df025b0](df025b0)) * Fix Test (wrong order of arguments) ([#2780](#2780)) ([02f467e](02f467e)) * Fix/prove issues [#2733](#2733) [#2735](#2735) [#2763](#2763) [#2767](#2767) ([#2777](#2777)) ([7b1c67e](7b1c67e)) * Prove problems with procedure resource data types ([#2782](#2782)) ([68d0318](68d0318)) * read after create ([#2718](#2718)) ([2e9b68f](2e9b68f)) * UNSET and empty SET in network policies ([#2759](#2759)) ([3eacb0b](3eacb0b)) * unset network policy should not have single quotes ([#2584](#2584)) ([8f2a363](8f2a363)) * Update failover group allowed integration types ([#2776](#2776)) ([efde48d](efde48d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
ref #2582
When unsetting,
NETWORK_POLICYshould not be enclosed between single quotes. This was not detected in the acceptance tests because these only covered user attachments; I added a test for an account attachment.