False positive updates on table fields

[iwahbe]

Terraform CLI and Provider Versions

Terraform v1.8.1
on darwin_arm64

• provider registry.terraform.io/snowflake-labs/snowflake v0.89.0

Terraform Configuration

terraform {
  required_providers {
    snowflake = {
      source  = "Snowflake-Labs/snowflake"
      version = ">= 0.1"
    }
  }

  required_version = ">= 1.2.0"
}

provider "snowflake" {}

resource "snowflake_database" "simple" {
  name    = "testing"
  comment = "test comment"
}


resource "snowflake_schema" "schema" {
  database            = snowflake_database.simple.name
  name                = "schema"
  data_retention_days = 1
}

resource "snowflake_sequence" "sequence" {
  database = snowflake_schema.schema.database
  schema   = snowflake_schema.schema.name
  name     = "sequence"
}

resource "snowflake_table" "table" {
  database                    = snowflake_schema.schema.database
  schema                      = snowflake_schema.schema.name
  name                        = "table"
  comment                     = "A table."
  cluster_by                  = ["to_date(DATE)"]
  data_retention_time_in_days = snowflake_schema.schema.data_retention_days
  change_tracking             = false

  column {
    name     = "id"
    type     = "int"
    nullable = true

    default {
      sequence = snowflake_sequence.sequence.fully_qualified_name
    }
  }

  column {
    name = "identity"
    type = "int"
    # type  = "NUMBER(38,0)" # Should be equivalent
    nullable = true

    identity {
      start_num = 1
      step_num  = 3
    }
  }

  column {
    name = "MY_STRING"
    type = "VARCHAR(16777216)"
    # type = "STRING" # Should be equivalent
  }

  column {
    name = "DATE"
    type = "TIMESTAMP_NTZ"
    # type = "TIMESTAMP_NTZ(9)" # Should be equivalent
  }

  column {
    name = "DATE2"
    type = "DATETIME"
    # type = "TIMESTAMP_NTZ" # Equivalent to TIMESTAMP_NTZ
  }

  primary_key {
    name = "my_key"
    keys = ["data"]
  }
}

Expected Behavior

I expect that when I run terraform apply, type "yes" and then run terraform apply again, there are no diffs. I expect that when I change a type to a semantically equivalent type there will be no diff.

Actual Behavior

When I run terraform apply on a newly created DB, I get this:

𝛌 terraform apply
snowflake_database.simple: Refreshing state... [id=testing]
snowflake_schema.schema: Refreshing state... [id=testing|schema]
snowflake_sequence.sequence: Refreshing state... [id=testing|schema|sequence]
snowflake_table.table: Refreshing state... [id=testing|schema|table]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # snowflake_table.table will be updated in-place
  ~ resource "snowflake_table" "table" {
        id                          = "testing|schema|table"
        name                        = "table"
        # (8 unchanged attributes hidden)

      ~ column {
            name           = "id"
          ~ type           = "NUMBER(38,0)" -> "int"
            # (4 unchanged attributes hidden)

            # (1 unchanged block hidden)
        }
      ~ column {
            name           = "identity"
          ~ type           = "NUMBER(38,0)" -> "int"
            # (4 unchanged attributes hidden)

            # (1 unchanged block hidden)
        }
      ~ column {
            name           = "DATE"
          ~ type           = "TIMESTAMP_NTZ(9)" -> "TIMESTAMP_NTZ"
            # (4 unchanged attributes hidden)
        }
      ~ column {
            name           = "DATE2"
          ~ type           = "TIMESTAMP_NTZ(9)" -> "DATETIME"
            # (4 unchanged attributes hidden)
        }

        # (2 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.
╷
│ Warning: Argument is deprecated
│ 
│   with provider["registry.terraform.io/snowflake-labs/snowflake"],
│   on main.tf line 21, in provider "snowflake":
│   21: provider "snowflake" {}
│ 
│ Specify the region as part of the account parameter
│ 
│ (and 2 more similar warnings elsewhere)
╵

Steps to Reproduce

1. terraform apply
2. terraform apply again to see the diff

How much impact is this issue causing?

Medium

Logs

https://gist.github.com/iwahbe/4a5feacb7be90ec0d827a44b54de4cf0

Additional Information

There is already some code to normalize these values: https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/a70d1afc607c5e9501762448a96a11c22efca3d4/pkg/resources/table.go#L64C2-L64C3

The bug was originally discovered in Pulumi as pulumi/pulumi-snowflake#572.

[sfc-gh-asawicki]

Hey @iwahbe. Thanks for reaching out to us.

I will try to reproduce it this week and I will get back to you.

[sfc-gh-asawicki]

Hey @iwahbe. I have added a diff suppression for data types. After merging it should be a part of the next release.

It will still be subject to change as part of table rework in https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/ROADMAP.md#preparing-essential-ga-objects-for-the-provider-v1 but should work for the time being.

[iwahbe]

Thanks for getting to this @sfc-gh-asawicki! I appreciate it.

[sfc-gh-jcieslak]

Hey @iwahbe 👋
Could you confirm that the newly released version fixed your issue? If it did, please close the ticket. Thanks!

[iwahbe]

Looks fixed to me.