-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use materialized views and views from SDK #2448
Merged
sfc-gh-asawicki
merged 22 commits into
main
from
use-materialized-views-and-views-from-sdk
Feb 1, 2024
+963
−1,423
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
9f18404
Use SDK for materialized views datasource
sfc-gh-asawicki 300e1cc
Use SDK for views datasource
sfc-gh-asawicki 2aae3e3
Use SDK for drop views and materialized views
sfc-gh-asawicki 2130221
Use SDK for create views and materialized views
sfc-gh-asawicki 922af6b
Use SDK for read views and materialized views
sfc-gh-asawicki f294fea
Use SDK for update views and materialized views
sfc-gh-asawicki 802d42b
Set/unset tags for materialized view
sfc-gh-asawicki 7c95cf2
Update TODO comments with issue numbers
sfc-gh-asawicki 434ee81
Migrate existing tests (WIP)
sfc-gh-asawicki 0caefe0
Pass view tests
sfc-gh-asawicki ca7b868
Pass materialized view tests
sfc-gh-asawicki 9ed83b6
Test changing the query externally
sfc-gh-asawicki b010534
Test set/unset tags for materialized view
sfc-gh-asawicki ea6a992
Test rename for materialized view
sfc-gh-asawicki 0528f7a
Add tests for rename and tags to view
sfc-gh-asawicki b3447ab
Add conflicts with to notification integration
sfc-gh-asawicki 986b644
Remove test and add test for #2085
sfc-gh-asawicki a9454d1
Fix test
sfc-gh-asawicki c4f4b88
Add tests to SDK
sfc-gh-asawicki 9dfb9dd
Fixed after reviews
sfc-gh-asawicki 3ef3f37
Merge branch 'main' into use-materialized-views-and-views-from-sdk
sfc-gh-asawicki 7d556fd
Use acceptance test warehouse
sfc-gh-asawicki File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this throw an error if no materialized views are found?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, but it can fail for other reasons (e.g. not existing schema - added test to SDK to show that).