Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Snowflake_Warehouse Resource Limits Max Cluster Count #2948

Closed
1 task
bdumford-OM1 opened this issue Jul 18, 2024 · 4 comments · Fixed by #2933
Closed
1 task

[Bug]: Snowflake_Warehouse Resource Limits Max Cluster Count #2948

bdumford-OM1 opened this issue Jul 18, 2024 · 4 comments · Fixed by #2933
Labels
bug Used to mark issues with provider's incorrect behavior

Comments

@bdumford-OM1
Copy link

Terraform CLI Version

1.5.3

Terraform Provider Version

0.93.0

Terraform Configuration

resource "snowflake_warehouse" "warehouse" {
  ...
  max_concurrency_level               = var.warehouse_max_concurrency_level
}

Category

category:resource

Object type(s)

resource:warehouse

Expected Behavior

The documentation for the snowflake_warehouse does say that the max_cluster_count parameter is ranged from 1-10. However, not every Snowflake account is limited to only 10 clusters on a given warehouse. We have a warehouse that has a max cluster count value of 20. I would expect the proper behavior to be that terraform would throw an apply error if the max cluster count exceeded what is allowed on the Snowflake account. I would not expect a plan error, but that's exactly what I'm getting. We did not have this problem in the provider version 0.92.0.
warehouse

Actual Behavior

The following plan error is thrown:

│ Error: expected max_cluster_count to be in the range (1 - 10), got 20
│ 
│   with snowflake_warehouse.warehouse,
│   on warehouses.tf line 65, in resource "snowflake_warehouse" "warehouse":
│   65:   max_cluster_count                   = var.warehouse_max_cluster_count

Steps to Reproduce

Create a warehouse using the snowflake_warehouse resource using provider version 0.93.0. Set max_cluster_count to a value >10.

How much impact is this issue causing?

Medium

Logs

No response

Additional Information

Our Snowflake account allows >10 max clusters per warehouse. This differs from the Snowflake documentation, but I'm sure there are other users out there that are allowed >10 clusters on their warehouse that will be affected by this.

Would you like to implement a fix?

  • Yeah, I'll take it 😎
@bdumford-OM1 bdumford-OM1 added the bug Used to mark issues with provider's incorrect behavior label Jul 18, 2024
@sfc-gh-asawicki
Copy link
Collaborator

Hey @bdumford-OM1. Thanks for reaching out to us.

You are right; it was once fixed (in #1919), but v0.93.0 introduced the same validation again. We will roll it back in v0.94.0 (expected next week on Wednesday/Thursday).

@bdumford-OM1
Copy link
Author

Thanks @sfc-gh-asawicki! I was going to post that I'm not even able to work around this by adding max_cluster_count to a lifecycle -> ignore_changes block. But if it's going to be rolled back next week, I will just wait for that version.

@sfc-gh-asawicki
Copy link
Collaborator

Hey @bdumford-OM1, I have relaxed the validations in #2959. It will be part of the v0.94 release (tomorrow morning CEST).

sfc-gh-asawicki added a commit that referenced this issue Jul 26, 2024
- Unskip cortex acceptance test
- Fix application package tests after recent SF release
- Relax warehouse parameter validations upper bounds
- Fix user tests after validation change for one of the params
- Fix cortex grant tests (they started to work)

References: #2948
sfc-gh-jcieslak pushed a commit that referenced this issue Jul 26, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.94.0](v0.93.0...v0.94.0)
(2024-07-26)


### 🎉 **What's new:**

* Add missing session parameters
([#2936](#2936))
([4ce662d](4ce662d))
* Adjust user SDK
([#2947](#2947))
([1127bb3](1127bb3))
* Better tests poc
([#2917](#2917))
([ef496c2](ef496c2))
* Introduce assertions generators part1
([#2952](#2952))
([1582a9f](1582a9f))
* Introduce assertions generators part2
([#2956](#2956))
([f715e8a](f715e8a))
* network policy v1 readiness
([#2914](#2914))
([3408c3f](3408c3f))
* Rework schema datasource
([#2954](#2954))
([f70e40e](f70e40e))
* Rework schema resource
([#2955](#2955))
([400a5c8](400a5c8))
* Role v1 readiness
([#2916](#2916))
([32c7690](32c7690))
* Schema SDK upgrade
([#2945](#2945))
([bca0836](bca0836))
* Streamlit v1 readiness
([#2930](#2930))
([aa42260](aa42260))


### 🔧 **Misc**

* Remove deprecation from unsafe execute
([#2941](#2941))
([ed712d7](ed712d7))
* Update documentation
([#2931](#2931))
([da98bc3](da98bc3))


### 🐛 **Bug fixes:**

* ATTRIBUTE set(string) parsing for cortex search service
([#2953](#2953))
([70a1c9a](70a1c9a))
* external function header parsing and add missing privileges
([#2961](#2961))
([9d882fe](9d882fe))
* Fix sync_password field for Azure scim clients
([#2950](#2950))
([6781133](6781133))
* Fix tests and relax warehouse validations
([#2959](#2959))
([dd01ce9](dd01ce9)),
closes
[#2948](#2948)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
@bdumford-OM1
Copy link
Author

Hey @bdumford-OM1, I have relaxed the validations in #2959. It will be part of the v0.94 release (tomorrow morning CEST).

Thanks for taking care of this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to mark issues with provider's incorrect behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants