fix: ATTRIBUTE set(string) parsing for cortex search service (#2953)

Fixes the issue pointed out in #2860 (comment) Verified in my local deployment PTAL @sfc-gh-asawicki @sfc-gh-mloring
Snowflake-Labs · Jul 23, 2024 · 70a1c9a · 70a1c9a
1 parent 1127bb3
commit 70a1c9a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/pkg/resources/cortex_search_service.go b/pkg/resources/cortex_search_service.go
@@ -147,9 +147,9 @@ func CreateCortexSearchService(ctx context.Context, d *schema.ResourceData, meta
 	if v, ok := d.GetOk("comment"); ok {
 		request.WithComment(v.(string))
 	}
-	if v, ok := d.GetOk("attributes"); ok && len(v.([]string)) > 0 {
+	if v, ok := d.GetOk("attributes"); ok && len(v.(*schema.Set).List()) > 0 {
 		attributes := sdk.AttributesRequest{
-			Columns: v.([]string),
+			Columns: expandStringList(v.(*schema.Set).List()),
 		}
 		request.WithAttributes(attributes)
 	}

diff --git a/pkg/resources/cortex_search_service_acceptance_test.go b/pkg/resources/cortex_search_service_acceptance_test.go
@@ -32,7 +32,7 @@ func TestAcc_CortexSearchService_basic(t *testing.T) {
 		}
 	}
 	variableSet2 := m()
-	variableSet2["attributes"] = config.ListVariable(config.StringVariable("type"))
+	variableSet2["attributes"] = config.SetVariable(config.StringVariable("type"))
 	variableSet2["warehouse"] = config.StringVariable(newWarehouseName)
 	variableSet2["comment"] = config.StringVariable("Terraform acceptance test - updated")
 

diff --git a/pkg/resources/testdata/TestAcc_CortexSearchService_basic/2/variables.tf b/pkg/resources/testdata/TestAcc_CortexSearchService_basic/2/variables.tf
@@ -9,7 +9,7 @@ variable "on" {
 }
 
 variable "attributes" {
-  type = list(string)
+  type = set(string)
 }
 
 variable "database" {