Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BPK-964] Upgrade eslint-config-skyscanner #226

Merged
merged 1 commit into from
Oct 27, 2017

Conversation

shaundon
Copy link
Contributor

@shaundon shaundon commented Oct 25, 2017

Upgrade eslint-config-skyscanner and remove rule opt-outs as they're in there now.

@shaundon shaundon force-pushed the bpk-964-eslint-config-skyscanner branch from 20c7bdd to b004eeb Compare October 25, 2017 13:51
@backpackbot
Copy link

backpackbot commented Oct 27, 2017

Messages
📖

Thanks for the PR 🎉.

Generated by 🚫 dangerJS

@matthewdavidson
Copy link
Contributor

The package-lock.json should have changed... I am surprised Danger never noticed this.

Copy link
Contributor

@matteo-hertel matteo-hertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@shaundon shaundon force-pushed the bpk-964-eslint-config-skyscanner branch from b004eeb to 6608af0 Compare October 27, 2017 09:09
@shaundon shaundon force-pushed the bpk-964-eslint-config-skyscanner branch from 6608af0 to ede1552 Compare October 27, 2017 09:48
@shaundon
Copy link
Contributor Author

@matthewdavidson you're right - not sure why it wasn't, but I've fixed it now.

Copy link
Contributor

@matthewdavidson matthewdavidson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaundon shaundon merged commit feda68a into master Oct 27, 2017
@shaundon shaundon deleted the bpk-964-eslint-config-skyscanner branch October 27, 2017 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants