Skip to content

Commit

Permalink
[BPK-964] Upgrade eslint-config-skyscanner
Browse files Browse the repository at this point in the history
  • Loading branch information
shaundon committed Oct 25, 2017
1 parent d6fb16d commit 20c7bdd
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 26 deletions.
26 changes: 1 addition & 25 deletions .eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -8,30 +8,6 @@
"max-len": [2, 120],
"react/jsx-filename-extension": 0,
"import/no-extraneous-dependencies": 0,
"react/prefer-stateless-function": [2, { "ignorePureComponents": true }],

// We've decided we don't want this for now as it makes writing JSX more painful.
// See https://github.com/airbnb/javascript/issues/1584#issuecomment-335667272
"function-paren-newline": 0,

// False positive on custom propTypes + isRequired. https://github.com/yannickcr/eslint-plugin-react/issues/1389
"react/no-typos": 0,

// See https://github.com/evcohen/eslint-plugin-jsx-a11y/issues/339
"jsx-a11y/anchor-is-valid": ["error", {
"components": ["Link"],
"specialLink": ["to"],
"aspects": ["noHref", "invalidHref", "preferButton"],
}],

// See https://github.com/evcohen/eslint-plugin-jsx-a11y/issues/282
// We should probably change our code to adhere to the standard here.
"jsx-a11y/label-has-for": [ 2, {
"components": [ "Label" ],
"required": {
"some": [ "nesting", "id" ]
},
"allowChildren": false
}]
"react/prefer-stateless-function": [2, { "ignorePureComponents": true }]
}
}
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
"enzyme-to-json": "^1.5.1",
"eslint": "^4.9.0",
"eslint-config-airbnb": "^16.1.0",
"eslint-config-skyscanner": "^2.0.0",
"eslint-config-skyscanner": "^3.0.0",
"eslint-plugin-import": "^2.8.0",
"eslint-plugin-jsx-a11y": "^6.0.2",
"eslint-plugin-react": "^7.4.0",
Expand Down

0 comments on commit 20c7bdd

Please sign in to comment.