Adapt itests to new netty release #4
Conversation
Signed-off-by: Holger Friedrich <[email protected]>
holgerfriedrich
force-pushed
the
pr-netty-itests
branch
from
aa7ce5a to
47e5bab
Compare
|
Thanks for doing this, do you know why this is needed and if it can be improved to not needing to be done? It creates another level of complexity that will prevent libraries from being kept up to date which is now a necessary evil to do because of security flaws need to be fixed and not ignored in the digital age we now live in. I have updated Netty a couple of times and previously this was not needed, so this must be a recent change. |
|
Netty is also a dependency of the Moquette MQTT broker which is used in the MQTT Binding integration tests which got revived with openhab#12431. The last Netty update was before those changes, see openhab#11863. |
|
@Skinah @wborn Hi, how do we proceed with this one? As far as I understood, there is no way around updating the bnd files, since they are required for our integration tests. I have to touch the corresponding bnd as well to re-enable the last of the itests that got disabled due to changes in core.... My recommendation would be to merge and complete the netty upgrade first. |
|
LGTM. RE my comments, this is not the place to discuss making changes, so lets merge as is. |
|
@Skinah thanks. I think it is up to you to merge, as I created the PR to your branch. |
…hab#15547) * [jsscripting] Rename parameter useIncludedLibrary to injectionCachingEnabled (#4) * [jsscripting] Improve README for cached library injection * Remove settings image Signed-off-by: Florian Hotze <[email protected]>
This is the output of mvn -DwithResolver. I had to do some changes to pom and java code, as ruuvigateway is currently disabled. But I wanted to include it as well, to ease the fixing of this test.