Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jsscripting] Rename library injection parameter & Improve docs #15547

Merged
merged 7 commits into from
Sep 26, 2023
Merged

[jsscripting] Rename library injection parameter & Improve docs #15547

merged 7 commits into from
Sep 26, 2023

Conversation

florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented Sep 4, 2023 •
edited
Loading

Renames the useIncludedLibrary parameter to injectionCachingEnabled and updates label, description and options to be more descriptive of what the parameter is actually doing.

Also improve the docs to provide more guidance for add-on configuration.

@florian-h05 florian-h05 marked this pull request as draft September 4, 2023 22:12
@florian-h05 florian-h05 changed the title [WIP] [] [WIP] [jsscripting] Improve library injection param name Sep 4, 2023
@florian-h05 florian-h05 changed the title [WIP] [jsscripting] Improve library injection param name [WIP] [jsscripting] Improve library injection parameter & docs Sep 4, 2023
@florian-h05 florian-h05 changed the title [WIP] [jsscripting] Improve library injection parameter & docs [WIP] [jsscripting] Rename library injection parameter & Improve docs Sep 4, 2023
@florian-h05
Fix Spotless
8793d14 
Signed-off-by: Florian Hotze <[email protected]>
@florian-h05 florian-h05 changed the title [WIP] [jsscripting] Rename library injection parameter & Improve docs [jsscripting] Rename library injection parameter & Improve docs Sep 12, 2023
@florian-h05
Remove settings image
de0fe74 
Signed-off-by: Florian Hotze <[email protected]>
@florian-h05
Regenerate default translations
11c11e0 
Signed-off-by: Florian Hotze <[email protected]>
@florian-h05 florian-h05 marked this pull request as ready for review September 12, 2023 11:08
@florian-h05 florian-h05 requested a review from jlaur September 12, 2023 11:08
@florian-h05 florian-h05 marked this pull request as draft September 12, 2023 15:31
@florian-h05 florian-h05 marked this pull request as ready for review September 12, 2023 16:05
@florian-h05 florian-h05 marked this pull request as draft September 12, 2023 16:07
@florian-h05 florian-h05 changed the title [jsscripting] Rename library injection parameter & Improve docs [WIP] [jsscripting] Rename library injection parameter & Improve docs Sep 12, 2023
@florian-h05 florian-h05 removed the request for review from jlaur September 12, 2023 16:07
@florian-h05 florian-h05 changed the title [WIP] [jsscripting] Rename library injection parameter & Improve docs [jsscripting] Rename library injection parameter & Improve docs Sep 19, 2023
@florian-h05 florian-h05 marked this pull request as ready for review September 19, 2023 08:47
@florian-h05 florian-h05 requested review from jlaur and J-N-K and removed request for J-N-K September 19, 2023 08:47
@florian-h05
Copy link
Contributor Author

@jlaur Can you please review this PR?

jlaur
jlaur requested changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I have provided only a few comments for the README. I know it's copied over from the openhab-js repository, so please advise how these comments should be handled (if you agree).

bundles/org.openhab.automation.jsscripting/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.automation.jsscripting/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.automation.jsscripting/README.md Outdated Show resolved Hide resolved
@florian-h05
[jsscripting] Address review
f078b35 
Signed-off-by: Florian Hotze <[email protected]>
@florian-h05
Copy link
Contributor Author

@jlaur I addressed your comments on the README. This part of the README is not copied from openhab-js, only a part of the README is shared.

jlaur
jlaur approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur jlaur added the enhancement An enhancement or new feature for an existing add-on label Sep 26, 2023
@jlaur jlaur merged commit 99f0512 into openhab:main Sep 26, 2023
@jlaur jlaur added this to the 4.1 milestone Sep 26, 2023
@florian-h05 florian-h05 deleted the jsscripting-ohjs-injection branch September 26, 2023 20:59
Pshatsillo pushed a commit to Pshatsillo/openhab-addons that referenced this pull request Sep 29, 2023
@florian-h05 @Pshatsillo
[jsscripting] Rename library injection parameter & Improve docs (open…
941c57d 
…hab#15547)

* [jsscripting] Rename parameter useIncludedLibrary to injectionCachingEnabled (openhab#4)
* [jsscripting] Improve README for cached library injection
* Remove settings image

Signed-off-by: Florian Hotze <[email protected]>
pat-git023 pushed a commit to pat-git023/openhab-addons that referenced this pull request Oct 13, 2023
@florian-h05 @pat-git023
[jsscripting] Rename library injection parameter & Improve docs (open…
ef76e29 
…hab#15547)

* [jsscripting] Rename parameter useIncludedLibrary to injectionCachingEnabled (openhab#4)
* [jsscripting] Improve README for cached library injection
* Remove settings image

Signed-off-by: Florian Hotze <[email protected]>
querdenker2k pushed a commit to querdenker2k/openhab-addons that referenced this pull request Oct 21, 2023
@florian-h05 @querdenker2k
[jsscripting] Rename library injection parameter & Improve docs (open…
d0c1d70 
…hab#15547)

* [jsscripting] Rename parameter useIncludedLibrary to injectionCachingEnabled (openhab#4)
* [jsscripting] Improve README for cached library injection
* Remove settings image

Signed-off-by: Florian Hotze <[email protected]>
querdenker2k pushed a commit to querdenker2k/openhab-addons that referenced this pull request Oct 29, 2023
@florian-h05 @querdenker2k
[jsscripting] Rename library injection parameter & Improve docs (open…
55a991e 
…hab#15547)

* [jsscripting] Rename parameter useIncludedLibrary to injectionCachingEnabled (openhab#4)
* [jsscripting] Improve README for cached library injection
* Remove settings image

Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: querdenker2k <[email protected]>
florian-h05 added a commit to florian-h05/openhab-distro that referenced this pull request Nov 4, 2023
@florian-h05
Add breaking change warning for JS Scripting config param
10b2920 
Reference openhab/openhab-addons#15547.

Signed-off-by: Florian Hotze <[email protected]>
@florian-h05 florian-h05 mentioned this pull request Nov 4, 2023
Merged
wborn pushed a commit to openhab/openhab-distro that referenced this pull request Nov 12, 2023
@florian-h05
Add breaking change warning for JS Scripting config param (#1601)
0811429 
Reference openhab/openhab-addons#15547.

Signed-off-by: Florian Hotze <[email protected]>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@florian-h05 @austvik
[jsscripting] Rename library injection parameter & Improve docs (open…
5d555a6 
…hab#15547)

* [jsscripting] Rename parameter useIncludedLibrary to injectionCachingEnabled (openhab#4)
* [jsscripting] Improve README for cached library injection
* Remove settings image

Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Jørgen Austvik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@florian-h05 @jlaur