Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
this code very faster #539
base: master
Are you sure you want to change the base?
this code very faster #539
Changes from 2 commits
8b312ac
8d01fe0
f822607
de02fb4
563bde6
f18ee4f
583ff36
e12f0e1
f77c813
4002de3
6eb258e
c127789
2233557
ad0aca8
dac9130
e67b4ba
fcd533b
dd6029a
7d62722
c47575f
f895f71
062194d
5ba7883
ea2e5f5
8452bf8
6e764b1
8a89247
0262bcd
8dfd92c
7fbfb31
aa91e86
bbe3913
ea00553
a7f662f
5568e84
2f2179f
1e9ce56
0596d96
523793b
73eb309
b1dc8bc
33199aa
b2b8526
62678a7
25e118b
134eda2
8f3ec65
1909ecb
52f6b2f
aecbf93
d668311
1932175
6ba43c5
bcdcd55
62c2653
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question here. Previously the fallback was
[]
. Does your traversal treat an empty fields list as all fields allowed? Cause mine needed you to explicitly pass in the full list of fields, if that's what you wantedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
undefined
is all fields,[]
is noneThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok call, I'll update my change to use
undefined
when necessary