this code very faster #539

mProjectsCode · 2024-04-26T20:19:23Z

🦀
(feel free to change the name of this PR)

mProjectsCode · 2024-04-27T19:35:53Z

SkepticMystic

Looking good so far. I'm gonna try review frequently to keep the diff size small

src/components/codeblocks/CodeblockMermaid.svelte

wasm/src/graph.rs

src/commands/list_index/index.ts

src/components/EdgeLink.svelte

src/components/NestedEdgeList.svelte

src/components/codeblocks/CodeblockTree.svelte

src/commands/list_index/index.ts

SkepticMystic

Nice, continues to get closer :)

src/components/EdgeLink.svelte

wasm/src/graph.rs

…ermediate representation

fix PR

wasm/src/graph.rs

SkepticMystic

Nice, this is mcuh easier to understand now

src/components/page_views/TrailView.svelte

src/components/side_views/Matrix.svelte

src/components/side_views/TreeView.svelte

wasm/src/graph_traversal.rs

src/commands/freeze_edges/index.ts

mProjectsCode · 2024-05-02T19:52:25Z

Some preliminary performance metrics. (Take with a grain of salt, as with all benchmarks.)
Tested with 2564 notes in a tree shape. Each note has 1 to 3 explicit up frontmatter links. The tree is cut off at depth 10.
Transitive rules:

[up] <- down
[down] <- up
[same] <- same
[uncle] <- nephew
[nephew] <- uncle
[up, down] -> same
[up, same] -> uncle

This fork:

Initial Graph: ~4ms
Implied Edges: ~2.5ms
Total: ~18ms

Current Master (4.2.27) after running a few times to get JIT advantages:

Implied Edges: ~70ms
Total: ~85ms

This fork is about 4x faster regarding total time and about 25x faster in building implied edges.

Some fixes after a few tests

wasm/src/graph_data.rs

SkepticMystic

Maybe I'm missing something, but it seems alot of the references explicit need to be inverted

SkepticMystic · 2024-05-08T06:21:15Z

src/components/codeblocks/CodeblockTree.svelte

 		const traversal_options = new TraversalOptions(
-			[file_path],
-			options.fields ?? [],


Question here. Previously the fallback was []. Does your traversal treat an empty fields list as all fields allowed? Cause mine needed you to explicitly pass in the full list of fields, if that's what you wanted

undefined is all fields, [] is none

Ok call, I'll update my change to use undefined when necessary

SkepticMystic · 2024-05-08T06:30:02Z

wasm/src/graph_data.rs

@@ -79,21 +80,20 @@ impl EdgeData {
        // the mapping that exist on the JS side are as follows
        // "field" | "explicit" | "source" | "implied_kind" | "round"

-        // TODO: maybe change the attribute options so that the JS side better matches the data
-
+        // TODO(JS): maybe change the attribute options so that the JS side better matches the data


I could've named it better, but with the TODO(RUST) comments, I more just meant TODOs left for this PR, not where the todo needs to be done :)

wasm/src/graph_data.rs

wasm/src/graph_mermaid.rs

wasm/src/utils.rs

SkepticMystic · 2024-05-08T06:37:10Z

wasm/src/utils.rs

+        if self.stopped() {
+            LOGGER.warn(&format!("PerfLogger {} is already stopped", self.name));
+        } else {


If you double-check that it's not already stopped in this function, it feels unecessary to check this before calling self.stop() elsewhere

Kind of, the check here is to make sure that the place that is calling this checked stopped before.

wasm/src/utils.rs

wasm/tests/graph.rs

…wing all fields

mProjectsCode · 2024-05-08T09:34:58Z

Yep, it seems i was quite tired when I made those last few commits and missed a lot of places 😅

…adth_first

SkepticMystic · 2024-05-13T07:34:27Z

src/components/codeblocks/CodeblockMermaid.svelte


 	export const update = () => {
 		const max_depth = options.depth[1] ?? DEFAULT_MAX_DEPTH;

+		const source_path =  options["start-note"] || file_path || $active_file_store?.path || "";


file_path is start-note, if present

src/components/side_views/MatrixEdgeField.svelte

SkepticMystic · 2024-05-13T07:38:32Z

wasm/src/edge_sorting.rs

+    pub fn sort_edges(&self, graph: &NoteGraph, edges: &mut [EdgeStruct]) {
        let ordering = self.get_edge_ordering(graph);

-        edges.sort_by(|a, b| self.apply_edge_ordering(&ordering, a, b));
+        edges.sort_by(|a, b| self.apply_edge_ordering(ordering.as_ref(), a, b));
    }


Are these clippy suggestions? What do they mean?

I can explain this at some point in VC.

wasm/src/graph_mermaid.rs

Co-authored-by: Ross <[email protected]>

SkepticMystic

Nice, I like the use of getter_with_clone :)

SkepticMystic · 2024-05-17T06:52:07Z

wasm/src/graph_traversal.rs

+    pub fn to_paths(&self) -> Vec<Path> {
+        self.paths.clone()
+    }


Isn't this just a getter on self.paths

SkepticMystic · 2024-05-17T06:58:49Z

wasm/src/graph_traversal.rs

+
+#[wasm_bindgen]
+#[derive(Clone, Debug)]
+pub struct FlatRecTraversalResult {


Just at a glance, can we use this same struct to handle the flatten method on RecTraversalData? It seems there's some duplicated logic

it's similar, but there are some differences, though the names are too close for my liking. Maybe they can be put into one method though,

SkepticMystic

Nice, looking good

mProjectsCode added 2 commits April 26, 2024 22:17

rusty breadcrumbs

8b312ac

working graph building; mermaid

8d01fe0

minor changes

f822607

SkepticMystic reviewed Apr 28, 2024

View reviewed changes

src/components/codeblocks/CodeblockMermaid.svelte Outdated Show resolved Hide resolved

wasm/src/graph.rs Show resolved Hide resolved

progress on tree view

de02fb4

SkepticMystic reviewed Apr 29, 2024

View reviewed changes

mProjectsCode added 3 commits April 29, 2024 14:40

edge sorting

563bde6

fix list index

f18ee4f

fix edge link class

583ff36

SkepticMystic reviewed Apr 29, 2024

View reviewed changes

src/commands/list_index/index.ts Outdated Show resolved Hide resolved

SkepticMystic reviewed Apr 29, 2024

View reviewed changes

src/components/EdgeLink.svelte Outdated Show resolved Hide resolved

wasm/src/graph.rs Outdated Show resolved Hide resolved

wasm/src/graph.rs Outdated Show resolved Hide resolved

SkepticMystic and others added 6 commits April 29, 2024 17:08

Builders accumulate GraphConstructionData immediately, instead of int…

e12f0e1

…ermediate representation

Merge branch 'master' into mProjectsCode/master

f77c813

Merge pull request #1 from SkepticMystic/mProjectsCode/master

4002de3

fix PR

first half of mermaid options

6eb258e

Merge branch 'master' of https://github.com/mProjectsCode/breadcrumbs

c127789

mermaid code block collapse edge option

2233557

SkepticMystic reviewed Apr 29, 2024

View reviewed changes

wasm/src/graph.rs Outdated Show resolved Hide resolved

split up rust code

ad0aca8

SkepticMystic reviewed May 1, 2024

View reviewed changes

mProjectsCode added 3 commits May 1, 2024 14:34

traversal options

dac9130

fix more views

e67b4ba

it kind of works

fcd533b

SkepticMystic reviewed May 2, 2024

View reviewed changes

src/commands/freeze_edges/index.ts Outdated Show resolved Hide resolved

mProjectsCode added 3 commits May 2, 2024 17:27

fix traversal bug with trail view

dd6029a

fix more trail view things

7d62722

fix more bugs

c47575f

SkepticMystic added 2 commits May 7, 2024 11:57

Merge pull request #3 from mProjectsCode/mProjectsCode/master

bbe3913

Some fixes after a few tests

Merge branch 'master' into master

ea00553

mProjectsCode commented May 7, 2024

View reviewed changes

wasm/src/graph_data.rs Outdated Show resolved Hide resolved

SkepticMystic and others added 6 commits May 7, 2024 16:25

Remove some old TODOs + Add (RUST) label to existing ones

a7f662f

fix: Resolve merge-conflict conflicts

5568e84

wasm logging; rust script in package json

2f2179f

Merge branch 'master' of https://github.com/mProjectsCode/breadcrumbs

1e9ce56

adress some todos

0596d96

more minor fixes

523793b

SkepticMystic reviewed May 8, 2024

View reviewed changes

refactor: TraversalOptions.fields being undefined is the same as allo…

73eb309

…wing all fields

mProjectsCode and others added 6 commits May 8, 2024 11:35

fix review comments

b1dc8bc

feat: Implement basic flatten rec_traversal_data func + switch to bre…

33199aa

…adth_first

Merge branch 'master' of https://github.com/mProjectsCode/breadcrumbs

b2b8526

Reimplement flat option on CodeblockTree

62678a7

make clippy happy; work on todos

25e118b

mermaid edge sorting

134eda2

SkepticMystic reviewed May 13, 2024

View reviewed changes

mProjectsCode and others added 3 commits May 13, 2024 14:57

Update src/components/side_views/MatrixEdgeField.svelte

8f3ec65

Co-authored-by: Ross <[email protected]>

Update wasm/src/graph_mermaid.rs

1909ecb

Co-authored-by: Ross <[email protected]>

performance improvements to views

52f6b2f

SkepticMystic reviewed May 17, 2024

View reviewed changes

mProjectsCode added 3 commits May 25, 2024 23:21

some small improvements

aecbf93

do node stringification in rust

d668311

fix error, add debounce

1932175

SkepticMystic reviewed May 30, 2024

View reviewed changes

mProjectsCode added 3 commits December 15, 2024 12:19

update graph on vault events and code cleanup

6ba43c5

change update flow

bcdcd55

more cleanup; improve EdgeStruct perf

62c2653

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

this code very faster #539

this code very faster #539

mProjectsCode commented Apr 26, 2024

mProjectsCode commented Apr 27, 2024 •

edited

Loading

SkepticMystic left a comment

SkepticMystic left a comment

SkepticMystic left a comment

mProjectsCode commented May 2, 2024

SkepticMystic left a comment

SkepticMystic May 8, 2024

mProjectsCode May 8, 2024

SkepticMystic May 8, 2024

SkepticMystic May 8, 2024

SkepticMystic May 8, 2024

mProjectsCode May 8, 2024

mProjectsCode commented May 8, 2024

SkepticMystic May 13, 2024

mProjectsCode May 13, 2024

SkepticMystic May 13, 2024

mProjectsCode May 13, 2024

SkepticMystic left a comment

SkepticMystic May 17, 2024

SkepticMystic May 17, 2024

mProjectsCode May 25, 2024

SkepticMystic left a comment

this code very faster #539

Are you sure you want to change the base?

this code very faster #539

Conversation

mProjectsCode commented Apr 26, 2024

mProjectsCode commented Apr 27, 2024 • edited Loading

SkepticMystic left a comment

Choose a reason for hiding this comment

SkepticMystic left a comment

Choose a reason for hiding this comment

SkepticMystic left a comment

Choose a reason for hiding this comment

mProjectsCode commented May 2, 2024

SkepticMystic left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mProjectsCode commented May 8, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SkepticMystic left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SkepticMystic left a comment

Choose a reason for hiding this comment

mProjectsCode commented Apr 27, 2024 •

edited

Loading