Enable .NET 6 Preview Builds #1745
Conversation
ci-build.ps1
Outdated
| dotnet clean -c Release | ||
|
|
||
| $repositoryUrl = "https://github.com/$env:GITHUB_REPOSITORY" | ||
|
|
||
| # Building for a specific framework. | ||
| dotnet build -c Release -f $targetFramework /p:RepositoryUrl=$repositoryUrl |
There was a problem hiding this comment.
This will build every target making the builds longer, won't this?
Does the target framework impact the compiler version, isn't it purely an SDK thing?
There was a problem hiding this comment.
Yep so I had this badly wrong. My understanding was that specifying the target framework moniker causes the underlying MsBuild call to look for and use that specific SDK to compile against. That's obviously not true.
I've fixed up the project now so we can build against the preview in CI and everything else is unaffected. I got the langversion working properly also so we can use the C#9 features.
Codecov Report
@@ Coverage Diff @@
## master #1745 +/- ##
=======================================
Coverage 84.46% 84.46%
=======================================
Files 836 836
Lines 36737 36737
Branches 4306 4306
=======================================
Hits 31029 31029
Misses 4876 4876
Partials 832 832
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This reverts commit a525a42.
JimBobSquarePants
changed the title
|
Think I might just flatten this one when I merge it 😝 |
|
We should consider dropping netcoreapp2.1 for the 2.0 release. It's going out of support this month. |
|
@iamcarbon It’s only V2.0 because we have to introduce the breaking changes in #1730 My plan following this release is to immediately start work on V3.0 which will reduce the target frameworks to a minimum of .NET Core 3.1 As such this will act as the last stable release for legacy platforms. |
| @@ -257,7 +257,7 @@ protected override void OnFrameApply(ImageFrame<TPixel> source) | |||
| [MethodImpl(InliningOptions.ShortMethod)] | |||
| private void AddPixelsToHistogram(ref Vector4 greyValuesBase, ref int histogramBase, int luminanceLevels, int length) | |||
| { | |||
| for (int idx = 0; idx < length; idx++) | |||
| for (nint idx = 0; idx < length; idx++) | |||
There was a problem hiding this comment.
@JimBobSquarePants could you explain a bit what the advantages of using nint is? This is kind of new to me.
There was a problem hiding this comment.
Basically better codegen.
Prerequisites
Description
Just use the environment compiler to build things. When consumers build their applications they're already consuming a prebuilt binary. We only need to test with individual frameworks.Added .NET 6 Preview builds to the matrix and fixed up the solution to handle that scenario. Also fixed the langversion to C#9
This allows us to use features like
nintand also build/test against .NET 6 previews which we sorely need to do.