-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build against .NET 5 and .NET 6 #216
Build against .NET 5 and .NET 6 #216
Conversation
FYI GitHub Actions soon won't be able to build .NET Core 2.1 projects anymore: actions/runner-images#4871. Because it's already out of support, I recommend dropping this framework version before v2 ships. |
I won’t be dropping it while it’s still supported. V2 is designed as a baseline so I can drop targets with V3. (Same principle upstream with ImageSharp. Regarding this PR. You’ll need to wire things up for testing against .NET 5/6 in the same manner as ImageSharp |
Codecov Report
@@ Coverage Diff @@
## main #216 +/- ##
===================================
Coverage 85% 85%
===================================
Files 71 71
Lines 1945 1945
Branches 286 286
===================================
Hits 1672 1672
Misses 195 195
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
I've implemented a similar build pipeline as ImageSharp and everything seems to build fine (it just needs a different required check for code coverage: |
2.1 is already EOL and unsupported since August 21, 2021, and in 11 days it's also gone from GH Actions. |
Unsupported by Microsoft yes, but that doesn't stop people from still using it 😉 .NET Core 2.1 won't be included on the default images of GitHub Actions, but that isn't a problem as this build script already installs all required .NET SDKs... And as @JimBobSquarePants mentioned, dropping support can be done in the next major version, so it aligns with the ImageSharp library. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. Thanks!
Prerequisites
Description
I noticed ImageSharp already added .NET 5 and .NET 6 builds in SixLabors/ImageSharp#1745, but ImageSharp.Web is still only built against .NET Core 2.1 (support ended on August 21, 2021) and .NET Core 3.1 (support ends December 3, 2022, see MS support policy).