replace deprecated ImagingPlane parameters #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should merge this into the main version after we are done with the |
ageorgou
reviewed
Aug 20, 2020
tests/test_labview_import.py
Outdated
Comment on lines
35
to
40
| # ('161215_15_58_52'), | ||
| # ('161215_15_34_21'), | ||
| # ('170317_10_11_01'), | ||
| # ('170322_14_06_43'), | ||
| # ('161222_16_18_47'), | ||
| # ('170714_22_26_27') |
There was a problem hiding this comment.
These should be reenabled before merging!
alessandrofelder
force-pushed
the
replace_manifold
branch
from
095cdc3 to
f280d68
Compare
ageorgou
requested changes
Aug 27, 2020
The ImagingPlane constructor arguments "manifold", "unit" and "conversion" are deprecated from pynwb 1.3.0. This commit bumps the pynwb version up to 1.3.2 and replaces this deprecated parameters with recommended replacements.
grid_spacing written as float64 on Travis, but as float32 on local Windows...
changes in signature due to - replacing manifold with origin_coords and grid_spacing - having added pixel_time_offsets a few commits ago
improve add_imaging_plane docstring (fix parameter name in docstring) grid_spacing now consistent with earlier versions of code (implied by the manifold values)
alessandrofelder
force-pushed
the
replace_manifold
branch
from
f280d68 to
8da7a1b
Compare
Some environments would write this as 64 bits, making signature comparisons harder (and this could not be fixed by casting the value before the signature, as the value itself would have changed, not just the number of bits used). This changes the spacing of the grid slightly compared to when we were storing the manifold explicitly, but I think the differences are at atomic scale... Also updating the signatures for the larger files.
ageorgou
force-pushed
the
replace_manifold
branch
from
bccb10b to
05b2852
Compare
ageorgou
approved these changes
Aug 27, 2020
This was referenced Aug 27, 2020
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ImagingPlane constructor arguments "manifold", "unit" and "conversion" are deprecated, starting from pynwb 1.3.0.
This commit bumps the pynwb version up to 1.3.2 and replaces these deprecated parameters with recommended replacements.
Addresses #63 .