Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devices missing from signatures #27

Closed
ageorgou opened this issue Mar 17, 2020 · 1 comment
Closed

Devices missing from signatures #27

ageorgou opened this issue Mar 17, 2020 · 1 comment
Labels
test Tests for the code and data used for them

Comments

@ageorgou
Copy link
Contributor

This is only to keep track of this minor issue so we are not surprised.

The signatures we generate with some versions of pynwb are missing all information about the devices, even though the devices are correctly included in the file. This is because the group for each device only has 3 attributes (namespace, neurodata_type and object_id), all of which are ignored, leading to an empty signature. We also pass the description attribute, but this is not written to the file for some versions (it used to be but then stopped).

This should be fixed with pynwb version 1.3.0, which supports NWB schema version 2.2.2 (bringing back description).

@ageorgou ageorgou added the test Tests for the code and data used for them label May 14, 2020
@ageorgou
Copy link
Contributor Author

This should be fine after updating to 1.3.2 in #65.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Tests for the code and data used for them
Projects
None yet
Development

No branches or pull requests

1 participant