Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(blocks): Various block QoL improvements #8749

Merged
merged 91 commits into from
Nov 27, 2024
Merged

feat(blocks): Various block QoL improvements #8749

merged 91 commits into from
Nov 27, 2024

Conversation

ntindle
Copy link
Member

@ntindle ntindle commented Nov 24, 2024 •
edited
Loading

There's a few QoL things I found when reviewing the webhooks PR for the github blocks

  • There's not a good way to get the patch out of the GitHub PR Trigger block
  • The GitHub comment block doesn't work with pull requests
  • the GitHub API wrapper always force redirects the API to the api.github endpoint
  • The ai text block doesn't tell you how to use it to fill fields

Changes 🏗️

Fixes/Changes the expected behaviors in a non breaking way for the above issues

Checklist 📋

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan

Test plan is simply an agent using the changes
image
pr trigger testat_v37.json: Note that this agent is tested on edit for a pr so I wasn't constantly recreating PRs on other repos

ntindle/gridfinity-space-optimizer#2

Pwuts and others added 30 commits October 17, 2024 00:11
@Pwuts
Add Graph.on_update, Block.on_node_update, Block.on_node_delete…
857ae69 
… hooks
@Pwuts
Add credentials injection to Graph.on_update etc hooks
2f405c3
@Pwuts
Add webhooks and their links to nodes to DB schema
921f614
@Pwuts
update webhooks db schema
946b35e
@Pwuts
Introduce PLATFORM_BASE_URL config attribute
dfe36c1
@Pwuts
Add WebhooksManager base and GitHub implementation + graph lifecycl…
321ef9d 
…e hooks + other infra
@Pwuts
Add webhook ingress endpoint
f4ce0f4
@Pwuts
fix(blocks): Allow having an input and output pin with the same name
40e846e
@Pwuts
fix bootstrapping issues
6dc9e0c
@Pwuts
hide input pins on webhook blocks
ab5b336
@Pwuts
dedup generateInputHandles
41ccae7
@Pwuts
refactor(backend): Make RedisEventQueue generic
a82acc7
@Pwuts
apply event type filter in webhook ingress endpoint
36b87eb
@Pwuts
add webhook ping endpoint
13e6a75
@Pwuts
hide payload input
f117d3f
@Pwuts
fix graph creation
c604d27
@Pwuts
fix enum usage
34d82bf
@Pwuts
smol cleanup
98aed6d
@Pwuts
fix webhook resource string formatting
9f37671
@Pwuts
add debug stuff for webhooks
e5c95f6
@Pwuts
fix webhook ingress URL
5e995f9
@Pwuts
fix github events
aa12a5a
@majdyz
Merge branch 'dev' of github.com:Significant-Gravitas/AutoGPT into re…
707df04 
…inier/open-1961-implement-github-on-pull-request-block
@majdyz
[Reduce code change size] Revert CreatableGraph/CreatableNode -> Grap…
5158b87 
…h/Node | Graph/Node -> GraphModel/NodeModel
@majdyz
[Reduce code change size] Take Redis generic refactor out of the PR
5e70973
@majdyz
Merge branch 'dev' into reinier/open-1961-implement-github-on-pull-re…
6885fa8 
…quest-block
@majdyz
Merge branch 'dev' of github.com:Significant-Gravitas/AutoGPT into re…
2734d83 
…inier/open-1961-implement-github-on-pull-request-block
@majdyz
Fix frontend_base_url / platform_base_url clash
19b38fb
@majdyz
Set default platform_base_url & fix agent output block bug
1a23591
@majdyz
Fix CORS issue, make ValueError 400, toast saveAgent HTTP error
0343402
@ntindle ntindle requested review from Torantulino and Bentlybro and removed request for a team November 24, 2024 08:32
@qodo-merge-pro Qodo Merge Pro
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Error Handling
The patch URL access in the run method doesn't have proper error handling if the request fails or returns non-200 status code

URL Manipulation
Simple string replacement of 'pull' with 'issues' in URLs could be fragile. Consider using URL parsing library for more robust handling

@ntindle ntindle requested a review from Pwuts November 24, 2024 08:45
@Pwuts Pwuts changed the title feat: changes for QoL of Webhook PR feat(blocks): Various block QoL improvements Nov 25, 2024
Base automatically changed from reinier/open-1961-implement-github-on-pull-request-block to dev November 25, 2024 17:42
@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Nov 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Nov 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@netlify Netlify
Copy link

netlify bot commented Nov 25, 2024 •
edited
Loading

✅ Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 371451c
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/67474543921c3c00084a518d

@netlify Netlify
Copy link

netlify bot commented Nov 27, 2024 •
edited
Loading

✅ Deploy Preview for auto-gpt-docs-dev canceled.

Name Link
🔨 Latest commit 371451c
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs-dev/deploys/6747454326bb6600083a1b5a

@ntindle ntindle mentioned this pull request Nov 27, 2024
Open
@ntindle ntindle enabled auto-merge (squash) November 27, 2024 01:49
@ntindle ntindle merged commit fd6c1d9 into dev Nov 27, 2024
19 checks passed
@ntindle ntindle deleted the ntindle/github-webhook-changes branch November 27, 2024 16:18
aarushik93 pushed a commit that referenced this pull request Dec 1, 2024
@ntindle @aarushik93
feat(blocks): Various block QoL improvements (#8749)
fc4d1f7 
Co-authored-by: Reinier van der Leer <[email protected]>
Co-authored-by: Zamil Majdy <[email protected]>
Resolves #8357
Resolves #8738
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pwuts Pwuts Pwuts approved these changes

@Torantulino Torantulino Awaiting requested review from Torantulino Torantulino is a code owner automatically assigned from Significant-Gravitas/maintainers

@Bentlybro Bentlybro Awaiting requested review from Bentlybro Bentlybro is a code owner automatically assigned from Significant-Gravitas/maintainers

Assignees
No one assigned
Labels
platform/backend AutoGPT Platform - Back end platform/blocks Review effort [1-5]: 2 size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ntindle @Pwuts @majdyz