Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent use of webhook-triggered blocks if PLATFORM_BASE_URL is not set #8738

Closed
3 tasks done
Tracked by #8358
Pwuts opened this issue Nov 21, 2024 — with Linear · 0 comments
Closed
3 tasks done
Tracked by #8358

Prevent use of webhook-triggered blocks if PLATFORM_BASE_URL is not set #8738

Pwuts opened this issue Nov 21, 2024 — with Linear · 0 comments
Assignees
@Pwuts

Comments

@Pwuts Linear
Copy link
Member

Pwuts commented Nov 21, 2024 •
edited
Loading

TODO

  • Disable webhook-triggered blocks if PLATFORM_BASE_URL is not set
  • Raise error in BaseWebhooksManager on attempt to create webhook if PLATFORM_BASE_URL is not set
  • Add field validator for PLATFORM_BASE_URL
@Pwuts Pwuts self-assigned this Nov 21, 2024
@Pwuts Pwuts mentioned this issue Nov 21, 2024
Merged
14 tasks
Pwuts added a commit that referenced this issue Nov 21, 2024
@Pwuts
Prevent use of webhook system if PLATFORM_BASE_URL is not set
c2dd80b 
Resolves #8738

- Disable webhook blocks if `PLATFORM_BASE_URL` is not set
- Throw `MissingConfigError` when trying to set up a node-webhook-link if `PLATFORM_BASE_URL` is not set
- Add `MissingConfigError`
@Pwuts Pwuts closed this as completed Nov 21, 2024
@Pwuts Pwuts reopened this Nov 22, 2024
Pwuts added a commit that referenced this issue Nov 22, 2024
@Pwuts
Prevent use of webhook system if PLATFORM_BASE_URL is not set
6eb643d 
Resolves #8738

- Disable webhook blocks if `PLATFORM_BASE_URL` is not set
- Throw `MissingConfigError` when trying to set up a node-webhook-link if `PLATFORM_BASE_URL` is not set
- Add `MissingConfigError`
- Add field validator to `Config.platform_base_url` and `Config.frontend_base_url`
@Pwuts Pwuts closed this as completed Nov 22, 2024
ntindle added a commit that referenced this issue Nov 27, 2024
@ntindle
feat(blocks): Various block QoL improvements (#8749)
fd6c1d9 
Co-authored-by: Reinier van der Leer <[email protected]>
Co-authored-by: Zamil Majdy <[email protected]>
Resolves #8357
Resolves #8738
aarushik93 pushed a commit that referenced this issue Dec 1, 2024
@ntindle @aarushik93
feat(blocks): Various block QoL improvements (#8749)
fc4d1f7 
Co-authored-by: Reinier van der Leer <[email protected]>
Co-authored-by: Zamil Majdy <[email protected]>
Resolves #8357
Resolves #8738
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pwuts Pwuts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Pwuts