Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(backend): Rename & move IntegrationCredentialsStore to backend #8648

Merged

Conversation

ntindle
Copy link
Member

@ntindle ntindle commented Nov 14, 2024

  • Move autogpt_libs.supabase_integration_credentials_store into backend
    • .store -> backend.integrations.credentials_store
    • .types -> added to backend.data.model
  • Rename SupabaseIntegrationCredentialsStore to IntegrationCredentialsStore

We wanted to get a few security things in quickly in #8403 and had to make some compromises to do so. This picks those up and fixes them.

Checklist 📋

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:

…ialsStore

Rename autogpt_libs.supabase_integration_credentials_store to integration_credentials_stroe
Rename SupabaseIntegrationCredentialsStore to IntegrationCredentialsStore
@github-actions github-actions bot added documentation Improvements or additions to documentation platform/backend AutoGPT Platform - Back end platform/blocks size/l labels Nov 14, 2024
Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for auto-gpt-docs ready!

Name Link
🔨 Latest commit 46fb781
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/67499f802ba7cb000870eee3
😎 Deploy Preview https://deploy-preview-8648--auto-gpt-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ntindle ntindle marked this pull request as ready for review November 15, 2024 18:51
@ntindle ntindle requested a review from a team as a code owner November 15, 2024 18:51
@ntindle ntindle requested review from Swiftyos and Pwuts and removed request for a team November 15, 2024 18:51
Copy link

qodo-merge-pro bot commented Nov 15, 2024

PR Reviewer Guide 🔍

(Review updated until commit 1e78045)

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶

8540 - Partially compliant

Compliant requirements:

  • Added CLI helper for ENCRYPTION_KEY generation
  • Renamed SupabaseIntegrationCredentialsStore to IntegrationCredentialsStore
  • Added documentation for ENCRYPTION_KEY

Non-compliant requirements:

  • Locking mechanisms fixes not fully implemented
  • Some imports from backend still exist
⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Potential Bug
The credentials store initialization was simplified but may have lost important Redis configuration that was previously passed in

Code Design
The class was renamed but the internal implementation and dependencies remain largely unchanged, which may not fully address the original architectural concerns

@Pwuts Pwuts changed the title ref: Rename SupabaseIntegrationCredentialsStore to IntegrationCredent… refactor(platform): Rename SupabaseIntegrationCredentialsStore to IntegrationCredentialsStore Nov 18, 2024
@Pwuts Pwuts marked this pull request as draft November 18, 2024 10:57
@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Nov 18, 2024
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Nov 27, 2024
Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for auto-gpt-docs-dev ready!

Name Link
🔨 Latest commit 46fb781
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs-dev/deploys/67499f801a7a23000830a173
😎 Deploy Preview https://deploy-preview-8648--auto-gpt-docs-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Nov 27, 2024
Copy link
Contributor

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Nov 29, 2024
@ntindle ntindle requested review from Pwuts and majdyz November 29, 2024 07:33
aarushik93
aarushik93 previously approved these changes Nov 29, 2024
@Pwuts Pwuts force-pushed the ntindle/open-2006-clean-up-integration-credentials-storage-infra branch from ea17527 to 46fb781 Compare November 29, 2024 11:03
@Pwuts Pwuts changed the title refactor(platform): Rename SupabaseIntegrationCredentialsStore to IntegrationCredentialsStore refactor(backend): Rename & move SupabaseIntegrationCredentialsStore Nov 29, 2024
@Pwuts Pwuts changed the title refactor(backend): Rename & move SupabaseIntegrationCredentialsStore refactor(backend): Rename SupabaseIntegrationCredentialsStore & move to backend Nov 29, 2024
@Pwuts Pwuts changed the title refactor(backend): Rename SupabaseIntegrationCredentialsStore & move to backend refactor(backend): Rename & move IntegrationCredentialsStore to backend Nov 29, 2024
@aarushik93 aarushik93 added this pull request to the merge queue Nov 29, 2024
@Pwuts Pwuts removed this pull request from the merge queue due to a manual request Nov 29, 2024
@Pwuts Pwuts added this pull request to the merge queue Nov 29, 2024
Merged via the queue into dev with commit 75f9b07 Nov 29, 2024
21 checks passed
@Pwuts Pwuts deleted the ntindle/open-2006-clean-up-integration-credentials-storage-infra branch November 29, 2024 12:01
aarushik93 added a commit that referenced this pull request Dec 1, 2024
…kend (#8648)

- Move `autogpt_libs.supabase_integration_credentials_store` into
`backend`
   - `.store` -> `backend.integrations.credentials_store`
   - `.types` -> added to `backend.data.model`
- Rename `SupabaseIntegrationCredentialsStore` to
`IntegrationCredentialsStore`

We wanted to get a few security things in quickly in #8403 and had to
make some compromises to do so. This picks those up and fixes them.

- Resolves #8540

### Checklist 📋

#### For code changes:
- [x] I have clearly listed my changes in the PR description
- [x] I have made a test plan
- [x] I have tested my changes according to the test plan:
  <!-- Put your test plan here: -->

---------

Co-authored-by: Reinier van der Leer <[email protected]>
Co-authored-by: Aarushi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation platform/backend AutoGPT Platform - Back end platform/blocks platform/frontend AutoGPT Platform - Front end Review effort [1-5]: 3 size/l
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants