Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up integration credentials storage infra #8540

Closed
5 tasks done
Pwuts opened this issue Nov 4, 2024 — with Linear · 0 comments
Closed
5 tasks done

Clean up integration credentials storage infra #8540

Pwuts opened this issue Nov 4, 2024 — with Linear · 0 comments
Assignees
Labels
platform/backend AutoGPT Platform - Back end

Comments

Copy link
Member

Pwuts commented Nov 4, 2024

A few updates were made in the past weeks which have left some technical debt, including:

TODO

  • Docs and maybe a CLI helper for ENCRYPTION_KEY. Fernet has very specific requirements for what it accepts as an encryption key.
  • Fix SupabaseIntegrationCredentialsStore and IntegrationCredentialsManager locking mechanisms (see comment)
  • Rename SupabaseIntegrationCredentialsStore to IntegrationCredentialsStore
    • Rename autogpt_libs.supabase_integration_credentials_store to integration_credentials_stroe
  • Eliminate all imports from backend in autogpt_libs. This will probably involve moving IntegrationCredentialsStore to backend.
@Pwuts Pwuts added the platform/backend AutoGPT Platform - Back end label Nov 4, 2024 — with Linear
@ntindle ntindle self-assigned this Nov 14, 2024
@ntindle ntindle closed this as completed Nov 27, 2024
@ntindle ntindle reopened this Nov 29, 2024
github-merge-queue bot pushed a commit that referenced this issue Nov 29, 2024
…kend (#8648)

- Move `autogpt_libs.supabase_integration_credentials_store` into
`backend`
   - `.store` -> `backend.integrations.credentials_store`
   - `.types` -> added to `backend.data.model`
- Rename `SupabaseIntegrationCredentialsStore` to
`IntegrationCredentialsStore`

We wanted to get a few security things in quickly in #8403 and had to
make some compromises to do so. This picks those up and fixes them.

- Resolves #8540

### Checklist 📋

#### For code changes:
- [x] I have clearly listed my changes in the PR description
- [x] I have made a test plan
- [x] I have tested my changes according to the test plan:
  <!-- Put your test plan here: -->

---------

Co-authored-by: Reinier van der Leer <[email protected]>
Co-authored-by: Aarushi <[email protected]>
@ntindle ntindle closed this as completed Nov 29, 2024
aarushik93 added a commit that referenced this issue Dec 1, 2024
…kend (#8648)

- Move `autogpt_libs.supabase_integration_credentials_store` into
`backend`
   - `.store` -> `backend.integrations.credentials_store`
   - `.types` -> added to `backend.data.model`
- Rename `SupabaseIntegrationCredentialsStore` to
`IntegrationCredentialsStore`

We wanted to get a few security things in quickly in #8403 and had to
make some compromises to do so. This picks those up and fixes them.

- Resolves #8540

### Checklist 📋

#### For code changes:
- [x] I have clearly listed my changes in the PR description
- [x] I have made a test plan
- [x] I have tested my changes according to the test plan:
  <!-- Put your test plan here: -->

---------

Co-authored-by: Reinier van der Leer <[email protected]>
Co-authored-by: Aarushi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/backend AutoGPT Platform - Back end
Projects
None yet
Development

No branches or pull requests

2 participants