Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css style applied for title page #23

Closed
wants to merge 2 commits into from
Closed

css style applied for title page #23

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e07b69e
css style applied for title page
alsed Aug 13, 2024
269b199
Changes requested for pull request #23
alsed Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/OEBPS/Text/titlepage.xhtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@

<hr class="narrow"/>

<p class="title">Sigil User Guide</p>
<h1 class="title">Sigil User Guide</h1>

<p class="version">For Sigil Versions 2.3.0 and Later</p>
<h2 class="version">For Sigil Versions 2.3.0 and Later</h2>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with the style changes (especially after the new commit), but won't the title and version lines being changed from p to h1 cause new entries to be added to the generated TOC, ncx, nav, etc... ? Or am I missing something?

Unless I'm missing something

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If additional changes are needed, let me know.

<hr class="narrow"/>

<p class="author">The Sigil MobileRead Documentation Team:<br/><br/>
<p class="h1subheading">The Sigil MobileRead Documentation Team:<br/><br/>
Ashjuk<br/>
Banjo<br/>
BeckyEbook<br/>
Expand All @@ -30,6 +30,6 @@
Tex2002ans<br/>
User_Z</p>

<p class="author">Original Version by: Dave Heiland</p>
<p class="h1subheading">Original Version by: Dave Heiland</p>
</body>
</html>
</html>
4 changes: 2 additions & 2 deletions src/OEBPS/Text/toc.xhtml
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This suggestion is not the best, because it would force the need to repeat this change after each update of the HTML version of the Table of Contents. To be consistent with the h1 style of the entire publication, it would be better to modify the style for the div.sgc-toc-title class and load the appropriate font directly into the style assigned for the TOC (sgc-toc.css).

@font-face {
    font-family: 'SmallCaps';
    font-weight: bold;
    font-style: normal;
    font-variant: small-caps;
    src: url(../Fonts/Fontin-SmallCaps.otf);
}

div.sgc-toc-title {
    font-family: 'SmallCaps', sans-serif;
    font-size: 2em;
    font-weight: bold;
    font-variant: small-caps;
    text-align: center;
    margin-top: 0.0em;
    margin-bottom: 0.5em;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. That is what the sgc-toc.css file is for.

Happy to merge in your change once you adapt it following BeckyDTP comments.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on this comment, is it also better for the title page to maintain the class "author" and modify the font in the proper css file?

Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
<html xmlns="http://www.w3.org/1999/xhtml" xmlns:epub="http://www.idpf.org/2007/ops">
<head>
<title>Table of Contents</title>
<link href="../Styles/sgc-toc.css" rel="stylesheet" type="text/css"/>
<link href="../Styles/styles.css" rel="stylesheet" type="text/css"/>
</head>
<body>
<div class="sgc-toc-title">Table of Contents</div>
<h1 class="sgc-toc-title">Table of Contents</h1>
<div class="sgc-toc-level-1">
<a href="titlepage.xhtml">Title Page</a>
</div>
Expand Down