-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
css style applied for title page #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This suggestion is not the best, because it would force the need to repeat this change after each update of the HTML version of the Table of Contents. To be consistent with the h1 style of the entire publication, it would be better to modify the style for the div.sgc-toc-title class and load the appropriate font directly into the style assigned for the TOC (sgc-toc.css).
@font-face {
font-family: 'SmallCaps';
font-weight: bold;
font-style: normal;
font-variant: small-caps;
src: url(../Fonts/Fontin-SmallCaps.otf);
}
div.sgc-toc-title {
font-family: 'SmallCaps', sans-serif;
font-size: 2em;
font-weight: bold;
font-variant: small-caps;
text-align: center;
margin-top: 0.0em;
margin-bottom: 0.5em;
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. That is what the sgc-toc.css file is for.
Happy to merge in your change once you adapt it following BeckyDTP comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on this comment, is it also better for the title page to maintain the class "author" and modify the font in the proper css file?
Is our html TOC auto-generated from the NAV using Sigil? It makes sense if so. I guess I just never put two and two together. I'll need to remember that when adding chapters before releasing. Everything else about building/releasing the guide is fairly automated. |
Yes you recreate the HTML toc from the nav, then I always run the epub3 tool to update the toc.ncx and guide from the nav as well. That way even old epub2 e-readers still work. |
Makes sense. I don't think I've ever added a new chapter/xhtml file. I was worried for a second that I had no way of generating the ncx/TOC when automating new releases of the Guide with GitHub Actions. But there's no need. These things would happen locally and be pushed to the Guide's repo. All good. |
- reverted changes for pages, changes made in css stylesheet - for sgc-toc.css added font and h1 class - in style.css class author now has font assigned and size reduced to 1.2
Changes made as requested |
|
||
<p class="version">For Sigil Versions 2.3.0 and Later</p> | ||
<h2 class="version">For Sigil Versions 2.3.0 and Later</h2> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with the style changes (especially after the new commit), but won't the title and version lines being changed from p to h1 cause new entries to be added to the generated TOC, ncx, nav, etc... ? Or am I missing something?
Unless I'm missing something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If additional changes are needed, let me know.
I'm aware that the guideline stated that no aesthetics changes be proposed. In this regard: