Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css style applied for title page #23

Closed
wants to merge 2 commits into from
Closed

Conversation

alsed
Copy link

@alsed alsed commented Aug 13, 2024

  • stylesheet applied extensively for the title page.
  • stylesheet applied for the title of the toc page

I'm aware that the guideline stated that no aesthetics changes be proposed. In this regard:

  • No new fonts nor css have been created, only the current css style is applied.
  • The change is minimal, in order to preserve the overall document presentation.
  • The proposal also tried to add consistency to the document style.
  • This is a PROPOSAL, the person in charge must determine whether or not this is consistent with the design principles.
  • I DO believe this changes, while not totally correct, contribute to the presentation of the document.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This suggestion is not the best, because it would force the need to repeat this change after each update of the HTML version of the Table of Contents. To be consistent with the h1 style of the entire publication, it would be better to modify the style for the div.sgc-toc-title class and load the appropriate font directly into the style assigned for the TOC (sgc-toc.css).

@font-face {
    font-family: 'SmallCaps';
    font-weight: bold;
    font-style: normal;
    font-variant: small-caps;
    src: url(../Fonts/Fontin-SmallCaps.otf);
}

div.sgc-toc-title {
    font-family: 'SmallCaps', sans-serif;
    font-size: 2em;
    font-weight: bold;
    font-variant: small-caps;
    text-align: center;
    margin-top: 0.0em;
    margin-bottom: 0.5em;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. That is what the sgc-toc.css file is for.

Happy to merge in your change once you adapt it following BeckyDTP comments.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on this comment, is it also better for the title page to maintain the class "author" and modify the font in the proper css file?

@dougmassay
Copy link
Contributor

Is our html TOC auto-generated from the NAV using Sigil? It makes sense if so. I guess I just never put two and two together. I'll need to remember that when adding chapters before releasing. Everything else about building/releasing the guide is fairly automated.

@kevinhendricks
Copy link
Contributor

Yes you recreate the HTML toc from the nav, then I always run the epub3 tool to update the toc.ncx and guide from the nav as well. That way even old epub2 e-readers still work.

@dougmassay
Copy link
Contributor

dougmassay commented Aug 14, 2024

Makes sense. I don't think I've ever added a new chapter/xhtml file. I was worried for a second that I had no way of generating the ncx/TOC when automating new releases of the Guide with GitHub Actions. But there's no need. These things would happen locally and be pushed to the Guide's repo. All good.

- reverted changes for pages, changes made in css stylesheet
- for sgc-toc.css added font and h1 class
- in style.css class author now has font assigned and size reduced to 1.2
@alsed
Copy link
Author

alsed commented Aug 16, 2024

Changes made as requested


<p class="version">For Sigil Versions 2.3.0 and Later</p>
<h2 class="version">For Sigil Versions 2.3.0 and Later</h2>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with the style changes (especially after the new commit), but won't the title and version lines being changed from p to h1 cause new entries to be added to the generated TOC, ncx, nav, etc... ? Or am I missing something?

Unless I'm missing something

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If additional changes are needed, let me know.

@alsed alsed closed this by deleting the head repository Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants