Fix annex_korea edge cases #177
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change partly includes upstream HPM updates to the decision, though it does try to preserve HFM specificities. * Leave Korea Westernised after annexation Behind the scenes Korea undergoes de-Westernisation in order to incorporate its provinces as Japanese colonies. This fixes the use of a `random_country` scope (which cannot target a non-existing country) that prevented proper (re-)Westernisation. As a knock-on effect, this should make late game liberation crises that go to war over Korea actually function. Without this change, the Liberate Country CB would fizzle on the second day of the war. * Properly set up the conquest war against player Korea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change partly includes upstream HPM updates to the decision, though
it does try to preserve HFM specificities.
Leave Korea Westernised after annexation
Behind the scenes Korea undergoes de-Westernisation in order to
incorporate its provinces as Japanese colonies. This fixes the use of
a
random_countryscope (which cannot target a non-existing country)that prevented proper (re-)Westernisation.
As a knock-on effect, this should make late game liberation crises
that go to war over Korea actually function. Without this change, the
Liberate Country CB would fizzle on the second day of the war.
Properly set up the conquest war against player Korea