Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some bugs for everywhere #140

Open
wants to merge 11 commits into
base: Development
Choose a base branch
from
Open

Conversation

HKKNNT
Copy link

@HKKNNT HKKNNT commented Aug 27, 2018

since you must have these provinces before release it
and removed 1 line of AUS.txt that already have(and better) in following event

HKKNNT added 4 commits August 23, 2018 17:55
clean up
following event 60055558 did the same thing
Fixed the bug that cause Natal never released
fix those raid event which missed tag
@HKKNNT HKKNNT closed this Aug 27, 2018
@HKKNNT HKKNNT reopened this Aug 27, 2018
@HKKNNT HKKNNT changed the title fix the bug that Natal won't appear fix some bugs for South Africa Aug 27, 2018
HKKNNT added 3 commits August 28, 2018 01:45
conflict with above trigger
wrong trigger
add back the missing 2582(Kotor) to the claim after 2582 was split out from AUS_780. 
Kotor (Venetian Albania): https://en.wikipedia.org/wiki/Venetian_Albania
@HKKNNT HKKNNT changed the title fix some bugs for South Africa fix some bugs for everywhere Sep 2, 2018
fix the haitian_integration_title wont display problem
Add back missing estonian culture for Greater Finland. In the old PDM mod it have a "embrace_estonians" decisions for both SCA and FIN.
Estonia have a much, much closer relationship in history than the "ugrian" in game, 
https://en.wikipedia.org/wiki/Estonia%E2%80%93Finland_relations
Unification proposals
In Finland, the idea of a unified Greater Finland gained popularity and influence rapidly in 1917, but lost support after World War II and the Continuation War.
In Estonia of 1917, 1918 and 1940, the president Konstantin Päts wished for a union of finnic countries in his political testament, writing an outline of a unification plan. He used the term "soomesugu" in Estonian to point to the people and countries of Finland and Estonia when talking about common border law.[3][4]
Add 1 line to fix a small display bug in for missing header when accepting alliance. Vanilla Vic2 is more than 8 years ago I dont know why it hasn't been fixed yet...
1743 is a province in Germany (1.27I)
Copy link

@rderekp rderekp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed that a lot of the non-ASCII character issues in events, decisions, and localisation files are because some of the files seem to be saved in UTF-8 encoding (or when people are editing them, they open them as UTF-8). Any of these text files should be in Windows-1252, which is what Vicky 2 seems to support.

@@ -85,7 +86,7 @@ neo_zelandais;Neo-Zelandais;;;;;;;;;;;;;x,,,,,,,,,,,,,,,,,,,,,,
OCC;Occitania;Occitanie;Occitania;;Occitania;;;;;;;;;x
OCC_ADJ;Occitan;Occitain;Occitanisch;;Occitano;;;;;;;;;x
OCC_reactionary;Partit Reiau-Alo;Partit Reiau-Alo;Partit Reiau-Alo;;Partit Reiau-Alo;;;;;;;;;;;x
OCC_liberal;Partit de lo Nacioun Óucitano;Partit de lo Nacioun Óucitano;Partit de lo Nacioun Óucitano;;;;;;;;;;;x
OCC_liberal;Partit de lo Nacioun Óucitano;Partit de lo Nacioun Óucitano;Partit de lo Nacioun Óucitano;;;;;;;;;;;x
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The letter Ā isn't in Vicky 2's charset. Is this the correct spelling in Occitan?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants