feat: add byte rate to producer API

[shivanshuraj1333]

fixes: https://github.com/SigNoz/engineering-pod/issues/2056

---

Important

Add byte rate metric to producer throughput overview in the producer API, updating query parameters and functions accordingly.

• Behavior:
  • Add byte rate metric to producer throughput overview in getProducerThroughputOverview() in http_handler.go.
  • Update query context to producer-throughput-overview-byte-rate in BuildQRParamsWithCache() in translator.go.
• Query Parameters:
  • Rename queryRangeParams to producerQueryRangeParams in getProducerThroughputOverview() in http_handler.go.
  • Update buildBuilderQueriesProducerBytes() to use byte_rate as query name in translator.go.
• Misc:
  • Change latencyColumn to byte_rate in getProducerThroughputOverview() in http_handler.go.
  • Update PanelType to Table in BuildQRParamsWithCache() in translator.go.

^{This description was created by for d016e49. It will automatically update as commits are pushed.}

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to d016e49 in 1 minute and 48 seconds

More details

• Looked at 164 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 4 drafted comments based on config settings.

1. pkg/query-service/app/http_handler.go:3202

• Draft comment:
  The variable name latencySeries is misleading as it now deals with byte rate. Consider renaming it to byteRateSeries for clarity.
• Reason this comment was not posted:
  Marked as duplicate.

2. pkg/query-service/app/http_handler.go:3221

• Draft comment:
  The function postprocess.TransformToTableForBuilderQueries is used for transforming the resultFetchLatency. Ensure that this function is appropriate for handling byte rate data as well.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The PR changes the query context from 'producer-throughput-overview-latency' to 'producer-throughput-overview-byte-rate'. However, the function name and variable names still refer to latency, which can be misleading. This should be updated to reflect the new context of byte rate.

3. pkg/query-service/app/integrations/messagingQueues/kafka/translator.go:283

• Draft comment:
  The function buildBuilderQueriesProducerBytes is used for building queries related to byte rate. Ensure that this function is appropriate for handling byte rate data as well.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The PR changes the query context from 'producer-throughput-overview-latency' to 'producer-throughput-overview-byte-rate'. However, the function name and variable names still refer to latency, which can be misleading. This should be updated to reflect the new context of byte rate.

4. pkg/query-service/app/integrations/messagingQueues/kafka/translator.go:279

• Draft comment:
  Avoid using the component/index.tsx file structure approach, as it makes it difficult to debug and find components using global search tools like VS Code.
• Reason this comment was not posted:
  Comment was on unchanged code.

Workflow ID: wflow_BwmxoRJ4eh9MoGAi

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[srikanthccv]

I see there is still a list panel type for one specific query https://github.com/shivanshuraj1333/signoz/blob/5e44803e47bbf95e54644e183a602a10b14da97b/pkg/query-service/app/integrations/messagingQueues/kafka/translator.go#L375. trying to understand, why do keep some for the table and some list?

[shivanshuraj1333]

the code that you highlighted is not used in the api/v1/messaging-queues/kafka/topic-throughput/producer API.
This API uses trace and metrics queries which under the hood uses table type table only.

For the highlighted one, it makes sense to use list, and it's powering another API api/v1/messaging-queues/kafka/span/evaluation