Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fixProducerAPI #6422

Merged
merged 2 commits into from
Nov 12, 2024
Merged

feat: fixProducerAPI #6422

merged 2 commits into from
Nov 12, 2024

Conversation

eKuG
Copy link
Contributor

@eKuG eKuG commented Nov 12, 2024

Summary

Related Issues / PR's

https://github.com/SigNoz/engineering-pod/issues/2002

Screenshots

NA

Affected Areas and Manually Tested Areas


Important

Switch getProducerThroughputOverview to use List instead of Series and update related query functions.

  • Behavior:
    • Modify getProducerThroughputOverview in http_handler.go to use List instead of Series for data handling.
    • Update latencyColumn to use List instead of Series.
    • Adjust data access to use pointers for service_name and topic.
  • Query Building:
    • Change PanelType from Table to List in BuildQRParamsWithCache and buildCompositeQuery in translator.go for specific contexts.
    • Add support for producer-throughput-overview-latency in buildCompositeQuery.
  • Misc:
    • Minor refactoring in http_handler.go to align with new data structure.

This description was created by Ellipsis for bf74ac7. It will automatically update as commits are pushed.

@github-actions github-actions bot added bug Something isn't working enhancement New feature or request docs required labels Nov 12, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 55a4056 in 54 seconds

More details
  • Looked at 83 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. pkg/query-service/app/http_handler.go:3224
  • Draft comment:
    Ensure serviceName and topicName are not nil before dereferencing. Add a nil check to prevent potential runtime panic.
  • Reason this comment was not posted:
    Comment did not seem useful.
2. pkg/query-service/app/http_handler.go:3262
  • Draft comment:
    Ensure topic and serviceName are not nil before dereferencing. Add a nil check to prevent potential runtime panic.
  • Reason this comment was not posted:
    Marked as duplicate.
3. pkg/query-service/app/integrations/messagingQueues/kafka/translator.go:287
  • Draft comment:
    Ensure that changing PanelType from PanelTypeTable to PanelTypeList is consistent with the rest of the codebase and intended behavior.
  • Reason this comment was not posted:
    Comment did not seem useful.
4. pkg/query-service/app/integrations/messagingQueues/kafka/translator.go:284
  • Draft comment:
    Avoid using the component/index.tsx file structure approach, as it makes it difficult to debug and find components using global search tools like VS Code.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_zr6j7WrEXROmwEAU


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on bf74ac7 in 34 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. pkg/query-service/app/integrations/messagingQueues/kafka/translator.go:367
  • Draft comment:
    The condition still includes producer-throughput-overview-latency, which contradicts the PR description. Please remove it if it's no longer needed.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable:
    The comment is incorrect because the condition no longer includes producer-throughput-overview-latency after the change. The comment seems to be based on outdated information or a misunderstanding of the diff. Therefore, the comment should be deleted as it does not reflect the current state of the code.
    I might be missing some context from the PR description, but based on the diff alone, the comment is incorrect. The condition was changed to remove producer-throughput-overview-latency, so the comment is not applicable.
    Even if the PR description mentioned producer-throughput-overview-latency, the code change clearly shows it was removed, making the comment irrelevant.
    Delete the comment because it is incorrect; the condition no longer includes producer-throughput-overview-latency.
2. pkg/query-service/app/integrations/messagingQueues/kafka/translator.go:367
  • Draft comment:
    The condition should include producer-throughput-overview-latency to align with the PR description changes.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_laMnwmlnDyS4Jhif


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@shivanshuraj1333 shivanshuraj1333 enabled auto-merge (squash) November 12, 2024 03:13
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@shivanshuraj1333 shivanshuraj1333 merged commit d1503f1 into develop Nov 12, 2024
17 of 22 checks passed
shivanshuraj1333 added a commit to shivanshuraj1333/signoz that referenced this pull request Dec 3, 2024
shivanshuraj1333 added a commit to shivanshuraj1333/signoz that referenced this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs shipped enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants