fix: open the timepicker on clicking the time picker input after closing the timezone picker by clicking outside it

[ahmadshaheer]

Summary

• fix the issue of clicking on time range input after closing the timezone picker not showing time picker

Related Issues / PR's

Part of https://github.com/SigNoz/engineering-pod/issues/2005

Screenshots

Before:

2024-11-25.11-14-01.mov

After:

2024-11-25.11-13-22.mov

Affected Areas and Manually Tested Areas

• time range picker

---

Important

Fixes issue in CustomTimePicker.tsx where time picker did not open after closing timezone picker by resetting activeView in handleOpenChange().

• Behavior:
  • Fixes issue in CustomTimePicker.tsx where clicking on time range input after closing timezone picker did not show time picker.
  • Resets activeView to 'datetime' in handleOpenChange() when popover is closed.

^{This description was created by for d37e5f5. It will automatically update as commits are pushed.}

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to d37e5f5 in 18 seconds

More details

• Looked at 12 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. frontend/src/components/CustomTimePicker/CustomTimePicker.tsx:156

• Draft comment:
  Setting the 'open' state in 'handleOpenChange' might lead to unexpected behavior if the 'open' state is not in sync with the actual visibility of the popover. Consider ensuring the 'open' state accurately reflects the popover's visibility.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The change made in the PR is straightforward and aligns with the intent described in the PR. However, I noticed a potential issue with the use of the 'open' state in the 'handleOpenChange' function. The function sets the 'open' state, which might lead to unexpected behavior if the 'open' state is not in sync with the actual visibility of the popover. This could be a source of bugs, especially if the 'open' state is used elsewhere in the component.

Workflow ID: wflow_lV9l4tApo9rkhgfH

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>