-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: display timezone adjusted time range in time picker #6521
feat: display timezone adjusted time range in time picker #6521
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to b66328e in 30 seconds
More details
- Looked at
66
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
3
drafted comments based on config settings.
1. frontend/src/components/CustomTimePicker/RangePickerModal.tsx:65
- Draft comment:
Ensure that thedayjs
timezone plugin is loaded before usingdayjs.tz
. This is necessary for the timezone adjustments to work correctly. This applies to all instances wheredayjs.tz
is used. - Reason this comment was not posted:
Comment did not seem useful.
2. frontend/src/container/TopNav/DateTimeSelectionV2/index.tsx:670
- Draft comment:
Ensure that thedayjs
timezone plugin is loaded before usingdayjs.tz
. This is necessary for the timezone adjustments to work correctly. This applies to all instances wheredayjs.tz
is used. - Reason this comment was not posted:
Marked as duplicate.
3. frontend/src/container/TopNav/DateTimeSelectionV2/index.tsx:614
- Draft comment:
Avoid using inline styles in React components. Instead, use external stylesheets, CSS classes, or styled components. This issue is also present in other parts of the code. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
Workflow ID: wflow_DPmojYGctva1U4OQ
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
4 similar comments
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
…zone picker by clicking outside (#6522)
89cb5af
into
feat/timezone-formatter-custom-hook-and-adjust-graphs-timezone
Summary
Related Issues / PR's
Part of https://github.com/SigNoz/engineering-pod/issues/2005
Screenshots
Before:
2024-11-25.09-22-49.mov
After:
2024-11-25.09-21-49.mov
Affected Areas and Manually Tested Areas