-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add github create and modify issue and add comment to issue act… #96
feat: add github create and modify issue and add comment to issue act… #96
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good added some comment non-blocking. The only other thing would say is to test this out and to add more examples for each plugin otherwise looks good to go :) Will approve just make sure to test before merging in rest can be done separately
description: "Integration with GitHub for adding comments to issues", | ||
actions: [addCommentToIssueAction], | ||
evaluators: [], | ||
providers: [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably want to add a provider that shows all the comments for an issue can be a follow up not urgent
description: "Integration with GitHub for creating issues in repositories", | ||
actions: [createIssueAction], | ||
evaluators: [], | ||
providers: [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here should be list of recent issues but not blocking
description: "Integration with GitHub for modifying existing issues", | ||
actions: [modifyIssueAction], | ||
evaluators: [], | ||
providers: [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can use same one as the in the add comment plugin
@monilpat @jkbrooks test results for create issue action below. Issue was successfully created here snobbee/test-repo#3
|
@monilpat update issue test result successfully updated issue snobbee/test-repo#3 (add label bug) results:
|
here is another test that updates the title: (snobbee/test-repo#3)
|
and test result for adding new comment to existing issue: snobbee/test-repo#3 (comment)
|
I'll help fill out the PR template based on the changes shown in the files.
Relates to:
plugin-github
Risks
Low - These changes add new GitHub issue management functionality through well-defined APIs
Background
What does this PR do?
Adds three new GitHub plugin actions for issue management:
What kind of change is this?
Features (non-breaking change which adds functionality)
Documentation changes needed?
My changes require a change to the project documentation to document the new issue management capabilities.
Testing
Where should a reviewer start?
The changes include proper error handling and logging throughout the new functionality.