Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add GitHub issue actions #101

Merged
merged 4 commits into from
Dec 12, 2024
Merged

Conversation

snobbee
Copy link
Collaborator

@snobbee snobbee commented Dec 12, 2024

Follow up on #96 to merge into sif-dev brannch

I'll help fill out the PR template based on the changes shown in the files.

Relates to:

plugin-github

Risks

Low - These changes add new GitHub issue management functionality through well-defined APIs

Background

What does this PR do?

Adds three new GitHub plugin actions for issue management:

  • CREATE_ISSUE: Creates new issues in GitHub repositories
  • MODIFY_ISSUE: Updates existing issues (title, body, state, labels)
  • ADD_COMMENT_TO_ISSUE: Adds comments to existing issues

What kind of change is this?

Features (non-breaking change which adds functionality)

Documentation changes needed?

My changes require a change to the project documentation to document the new issue management capabilities.

Testing

Where should a reviewer start?

  1. Review the three new plugin files:
  • packages/plugin-github/src/plugins/createIssue.ts
  • packages/plugin-github/src/plugins/modifyIssue.ts
  • packages/plugin-github/src/plugins/addCommentToIssue.ts
  1. Review the corresponding schema definitions in:
  • packages/plugin-github/src/types.ts
  • packages/plugin-github/src/templates.ts
  1. Verify error handling by testing with:
  • Invalid repository details
  • Non-existent issues
  • Missing permissions

The changes include proper error handling and logging throughout the new functionality.

@snobbee snobbee requested a review from monilpat December 12, 2024 16:35
@snobbee snobbee changed the title Feat/add GitHub issue actions feat: add GitHub issue actions Dec 12, 2024
@monilpat monilpat merged commit 6792a5c into sif-dev Dec 12, 2024
5 of 8 checks passed
@snobbee snobbee deleted the feat/add-github-issue-actions branch December 12, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants