separate patches into dedicated source files #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HSZemi
reviewed
Jan 28, 2021
patches/random_costs.cpp
Outdated
| } | ||
|
|
||
| bool hasNaturalResourceCost(const genie::Unit &unit) { | ||
| std::vector<ResourceCost> costs = unit.Creatable.ResourceCosts; |
There was a problem hiding this comment.
This looks like there are a few issues with spaces and tabs in this file 🤔
simonsan
reviewed
Jan 29, 2021
CMakeLists.txt
Outdated
| @@ -4,6 +4,19 @@ set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -static-libstdc++") | |||
| add_subdirectory(genieutils EXCLUDE_FROM_ALL) | |||
| include_directories( | |||
| "genieutils/include" | |||
| "." | |||
simonsan
approved these changes
Jan 29, 2021
|
Looks good, really like that change, much better overview and easier to add new mods in the future! 👍🏽 |
|
@FranciscoDA What did you use for code formatting, do you have a |
Manually formatted I'm afraid 😰 (although I honored the original formatting a bit) I've added a .clang-format file and reformatted the sources according to that. |
|
Thank you! 💛 |
|
Nice! 👍🏽 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.