Add AppBridgeMiddleware #1345
Add AppBridgeMiddleware #1345
Conversation
|
cc @NabeelAhsen |
|
When the "Add App" button is clicked, the app is prompted to initiate OAuth by visiting the app's login URL: The OAuth flow completes and correctly returns the |
| if request.params.has_key?("shop") && !request.params.has_key?("host") | ||
| shop = request.params["shop"] | ||
| host = Base64.urlsafe_encode64("#{shop}/admin", padding: false) | ||
| request.update_param("host", host) |
There was a problem hiding this comment.
From my understanding, the host parameter is subject to change; it's not always going to be the shop Base64 encoded.
|
@jesalerno84 @pepicrft Could I get your input here? I'm not convinced that this is a bug For context, @kirillplatonov suggests that this is critical to fix before releasing |
|
@NabeelAhsen I just double-checked and everything seems to work correctly without middleware. I definitely was able to reproduce this issue in November and had "APP::ERROR::INVALID_CONFIG: host must be provided" errors in Sentry after app install. Not sure if it was before or after login, to be honest. Let's close this for now then. I will keep an eye on Sentry and will let you know if the issue will happen again. |
What this PR does
When the app is installed via "Add app" button from the app store listing Shopify redirects the user to the login page without
hostparam:As a result, the app gets
AppBridge2 erroron the frontend and the user is stuck on the Splash screen. I had issues with this on production after AppBridge2.0 upgrade. I was talking with Shopify Partner support about this behavior and they said it's not a bug but the intended behavior 🤷♂️ Until this will change we need a middleware that will generatehostfrom theshopparam on the fly.