-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packaging for release v18.0.3 #1344
Conversation
@NabeelAhsen I have one more important bugfix for AppBridge 2. Preparing the PR now. |
I'll leave this release as a draft for now |
@NabeelAhsen In my fork, I also have |
@kirillplatonov I saw that as well, and thought it would be neat to have something like this! Although I would rethink the long-term costs of relying on cookies, especially for embedded apps. This gem has a lot of tech debt to pay regarding an over-reliance on cookies. We can't rely on 3p cookies set by embedded apps in the near future, and so the gem's been slowly trying to phase out any more writes performed on cookies within the gem. For example, I don't know how In any case, I don't think it's a blocker to getting this patch released. Thank you for your contributions 🎉 ! What do you think about this release? Is it ready to deploy? |
@NabeelAhsen Yeah, let's publish this patch. I will open a PR for |
What this PR does
This is a patch release that includes the following bug fixes:
EnsureAuthenticatedLinks
compatible with AppBridge 2.0. #1277host
parameter when redirecting to the splash page in an unauthenticated state.Checklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.md
if the changes would impact usersREADME.md
, if appropriate./docs
, if necessary