Rails 6.1 not yet supported #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
force-pushed
the
andyw8/rails-6.1-not-yet-supported
branch
2 times, most recently
from
680210e to
2eb2f27
Compare
andyw8
force-pushed
the
andyw8/rails-6.1-not-yet-supported
branch
from
2eb2f27 to
dc96643
Compare
mllemango
approved these changes
Jan 13, 2021
alexaitken
approved these changes
Jan 13, 2021
|
Just to clarify, this would only be for an embedded app, right? |
|
@axlekb Correct. Using the shopify_api gem directly is fine. |
|
Hi @andyw8, yes, I am aware that API would be unaffected as it doesn't require any cookies, however I was more wondering about cookies for oauth portion of this gem. We have a non-embedded app, and we are running 6.1... We haven't noticed any problems, but just want to make sure that I'm not missing anything. |
|
Hey @andyw8 👋 Does it really mandatory to restrict the Rails version to be < 6.1? # config/application.rb
config.load_defaults 6.1
config.action_dispatch.cookies_same_site_protection = nil |
kirillplatonov
pushed a commit
to kirillplatonov/shopify_app
that referenced
this pull request
Jan 26, 2021
This reverts commit 9951513. # Conflicts: # CHANGELOG.md
2 tasks
kirillplatonov
pushed a commit
to kirillplatonov/shopify_app
that referenced
this pull request
Feb 8, 2021
This reverts commit 9951513. # Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.mdif the changes would impact usersREADME.md, if appropriate.docs/, if necessary