This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
Add version constraints to 'create rails' #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
reviewed
Jan 29, 2021
mkevinosullivan
force-pushed
the
rails_lessthan_6_1
branch
from
19d61ed to
95aed7e
Compare
mkevinosullivan
force-pushed
the
rails_lessthan_6_1
branch
from
95aed7e to
faf7d46
Compare
mllemango
approved these changes
Feb 22, 2021
thecodepixi
approved these changes
Feb 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #1057
WHAT is this pull request doing?
Limits
railsinstallation to<6.1(due to Shopify/shopify_app#1134)Limits
shopify_appinstallation to>=17.0.3(due to Shopify/shopify_app#1097)Correction to version checking as
railsdoesn't follow Semantic Versioning format.Update checklist