Make cursor based pagination return relative uri's when fetching next and previous pages #726
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #713
Currently, when using REST based collection pagination, the request made using
.fetch_next_page
andfetch_previous_page
actually includes the base site twice.Normal request is fine:
but then fetching next or previous page results in the following request:
Strangely, Shopify works when calling the api like that most of the time.. but sometimes it randomly fails with a "522 - Bad Gateway" error.
This happens because the absolute url is passed from the pagination link headers, through to ActiveResource, which then merges the 'site' into the url again internally before making the request.
This pull request ensures we return a relative path (request_uri) instead of the absolute path when parsing the pagination link headers.
This ensures correctly formatted requests each time.